-
Notifications
You must be signed in to change notification settings - Fork 62
Open
Labels
refactorImproves code itself, but does not fix a bug or add new functionality.Improves code itself, but does not fix a bug or add new functionality.
Description
PR #889 refactored how we create decoders that take a file-like object. See the PR for full details. The state the code was left in, though, still has a not-great quirk that we're doing this:
- C++ creates object in
pybind_ops.cpp
, does areinterpret_cast<int64_t>
and returns that value to Python layer. - Python layer accepts the int and forwards that int decoder creation in
custom_ops.cpp
. - C++ in
custom_ops.cpp
does areinterpet_cast<AVIOFileLikeContext*>
on the int.
That's not great. The purpose of this issue is to investigate if defining an actual pybind object that wraps AVIOFileLikeContext
is better.
Metadata
Metadata
Assignees
Labels
refactorImproves code itself, but does not fix a bug or add new functionality.Improves code itself, but does not fix a bug or add new functionality.