Skip to content

Commit b1a575b

Browse files
authored
Merge pull request #66 from michalc/refactor/simplify-finalize
refactor: remove dead code to simplify finalization
2 parents 0af9bfc + 39fece7 commit b1a575b

File tree

1 file changed

+2
-10
lines changed

1 file changed

+2
-10
lines changed

sqlite_s3_query.py

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -295,11 +295,7 @@ def get_pp_stmt(statement):
295295
raise Exception('Attempting to use finalized statement') from None
296296

297297
def finalize(statement):
298-
# In case there are errors, don't attempt to re-finalize the same statement
299-
try:
300-
pp_stmt = statements.pop(statement)
301-
except KeyError:
302-
return
298+
pp_stmt = statements.pop(statement)
303299

304300
try:
305301
run_with_db(db, libsqlite3.sqlite3_finalize, pp_stmt)
@@ -323,11 +319,7 @@ def get_pp_stmts(sql):
323319
statements[statement] = pp_stmt
324320
yield partial(get_pp_stmt, statement), partial(finalize, statement)
325321

326-
try:
327-
yield get_pp_stmts
328-
finally:
329-
for statement in statements.copy().keys():
330-
finalize(statement)
322+
yield get_pp_stmts
331323

332324
def rows(get_pp_stmt, columns):
333325
while True:

0 commit comments

Comments
 (0)