avoid unnecessary copy for rcutils_char_array_vsprintf. (ros2#412) (ros2#413)

mergify[bot] · web-flow · commit dee753aca6a1 · 2023-03-02T17:46:46.000-08:00
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 1db1f16)
diff --git a/src/logging.c b/src/logging.c
@@ -950,14 +950,11 @@ void rcutils_logging_console_output_handler(
   }
 
   if (RCUTILS_RET_OK == status) {
-    va_list args_clone;
-    va_copy(args_clone, *args);
-    status = rcutils_char_array_vsprintf(&msg_array, format, args_clone);
+    status = rcutils_char_array_vsprintf(&msg_array, format, *args);
     if (RCUTILS_RET_OK != status) {
       RCUTILS_SAFE_FWRITE_TO_STDERR_WITH_FORMAT_STRING(
         "Error: rcutils_char_array_vsprintf failed with: %d\n", status);
     }
-    va_end(args_clone);
   }
 
   if (RCUTILS_RET_OK == status) {

Original file line number	Diff line number	Diff line change
`@@ -950,14 +950,11 @@ void rcutils_logging_console_output_handler(`
`950`	`950`	`}`
`951`	`951`
`952`	`952`	`if (RCUTILS_RET_OK == status) {`
`953`		`- va_list args_clone;`
`954`		`- va_copy(args_clone, *args);`
`955`		`- status = rcutils_char_array_vsprintf(&msg_array, format, args_clone);`
	`953`	`+ status = rcutils_char_array_vsprintf(&msg_array, format, *args);`
`956`	`954`	`if (RCUTILS_RET_OK != status) {`
`957`	`955`	`RCUTILS_SAFE_FWRITE_TO_STDERR_WITH_FORMAT_STRING(`
`958`	`956`	`"Error: rcutils_char_array_vsprintf failed with: %d\n", status);`
`959`	`957`	`}`
`960`		`- va_end(args_clone);`
`961`	`958`	`}`
`962`	`959`
`963`	`960`	`if (RCUTILS_RET_OK == status) {`