From 93f517fee2e09df6b3dfc6b360e7fe8976b7575f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nathan=20Gau=C3=ABr?= Date: Wed, 6 Aug 2025 13:48:13 +0200 Subject: [PATCH] [SPIR-V] Disable validation for a broken test The code emitted with this test would not pass validation rules for 06677 as the empty cbuffers generate a UniformConstant variable with no binding decoration. Seems like an oversight from DXC which would be OK if it only happened with `-fcgl` but since this also happens in `-O0` this is a bug. Related to #7681 --- .../test/CodeGenSPIRV/type.cbuffer.including.resource.hlsl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/clang/test/CodeGenSPIRV/type.cbuffer.including.resource.hlsl b/tools/clang/test/CodeGenSPIRV/type.cbuffer.including.resource.hlsl index f009467201..c8f8c0b132 100644 --- a/tools/clang/test/CodeGenSPIRV/type.cbuffer.including.resource.hlsl +++ b/tools/clang/test/CodeGenSPIRV/type.cbuffer.including.resource.hlsl @@ -1,4 +1,5 @@ -// RUN: %dxc -T ps_6_0 -E main -fcgl %s -spirv | FileCheck %s +// RUN: %dxc -T ps_6_0 -E main -fcgl -Vd %s -spirv | FileCheck %s +// FIXME(7681): Enable validation again once codegen is fixed. // CHECK-NOT: OpDecorate %buf3