From d8c82413669059d40fb54d79b7aed9483ddf3f9b Mon Sep 17 00:00:00 2001 From: rossrobino Date: Wed, 16 Jul 2025 11:32:42 -0400 Subject: [PATCH 1/3] fix: improve URLSearchParams constructor type --- inputfiles/addedTypes.jsonc | 15 --------------- inputfiles/overridingTypes.jsonc | 17 ++++++++++++++++- 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/inputfiles/addedTypes.jsonc b/inputfiles/addedTypes.jsonc index fbc48d8dd..d22c336bd 100644 --- a/inputfiles/addedTypes.jsonc +++ b/inputfiles/addedTypes.jsonc @@ -647,21 +647,6 @@ ] } }, - "URLSearchParams": { - "name": "URLSearchParams", - "constructor": { - "signature": { - "0": { - "param": [ - { - "name": "init", - "additionalTypes": ["URLSearchParams"] - } - ] - } - } - } - }, "NodeListOf": { "name": "NodeListOf", "typeParameters": [ diff --git a/inputfiles/overridingTypes.jsonc b/inputfiles/overridingTypes.jsonc index f8acee220..fafcf34be 100644 --- a/inputfiles/overridingTypes.jsonc +++ b/inputfiles/overridingTypes.jsonc @@ -3842,7 +3842,22 @@ } } } - } + }, + "URLSearchParams": { + "name": "URLSearchParams", + "constructor": { + "signature": { + "0": { + "param": [ + { + "name": "init", + "overrideType": "string | Iterable<[string, string]> | Record | URLSearchParams" + } + ] + } + } + } + } } }, "dictionaries": { From 8f653450fa4811ac0e9dd1c7f895c062023d89cb Mon Sep 17 00:00:00 2001 From: rossrobino Date: Wed, 16 Jul 2025 12:36:07 -0400 Subject: [PATCH 2/3] fix: remove URLSearchParams from overrideType in init parameter --- inputfiles/overridingTypes.jsonc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/inputfiles/overridingTypes.jsonc b/inputfiles/overridingTypes.jsonc index fafcf34be..5a8575139 100644 --- a/inputfiles/overridingTypes.jsonc +++ b/inputfiles/overridingTypes.jsonc @@ -3851,7 +3851,7 @@ "param": [ { "name": "init", - "overrideType": "string | Iterable<[string, string]> | Record | URLSearchParams" + "overrideType": "string | Iterable<[string, string]> | Record" } ] } From bfdab3e961ba13d0c1b682d390ea76b25dcd67c2 Mon Sep 17 00:00:00 2001 From: rossrobino Date: Wed, 16 Jul 2025 12:48:20 -0400 Subject: [PATCH 3/3] generate --- baselines/audioworklet.generated.d.ts | 2 +- baselines/dom.generated.d.ts | 2 +- baselines/serviceworker.generated.d.ts | 2 +- baselines/sharedworker.generated.d.ts | 2 +- baselines/ts5.5/audioworklet.generated.d.ts | 2 +- baselines/ts5.5/dom.generated.d.ts | 2 +- baselines/ts5.5/serviceworker.generated.d.ts | 2 +- baselines/ts5.5/sharedworker.generated.d.ts | 2 +- baselines/ts5.5/webworker.generated.d.ts | 2 +- baselines/ts5.6/audioworklet.generated.d.ts | 2 +- baselines/ts5.6/dom.generated.d.ts | 2 +- baselines/ts5.6/serviceworker.generated.d.ts | 2 +- baselines/ts5.6/sharedworker.generated.d.ts | 2 +- baselines/ts5.6/webworker.generated.d.ts | 2 +- baselines/webworker.generated.d.ts | 2 +- 15 files changed, 15 insertions(+), 15 deletions(-) diff --git a/baselines/audioworklet.generated.d.ts b/baselines/audioworklet.generated.d.ts index 1002c57b0..a01db288e 100644 --- a/baselines/audioworklet.generated.d.ts +++ b/baselines/audioworklet.generated.d.ts @@ -1396,7 +1396,7 @@ interface URLSearchParams { declare var URLSearchParams: { prototype: URLSearchParams; - new(init?: string[][] | Record | string | URLSearchParams): URLSearchParams; + new(init?: string | Iterable<[string, string]> | Record): URLSearchParams; }; /** diff --git a/baselines/dom.generated.d.ts b/baselines/dom.generated.d.ts index 31ae9872c..53b3c8455 100644 --- a/baselines/dom.generated.d.ts +++ b/baselines/dom.generated.d.ts @@ -33187,7 +33187,7 @@ interface URLSearchParams { declare var URLSearchParams: { prototype: URLSearchParams; - new(init?: string[][] | Record | string | URLSearchParams): URLSearchParams; + new(init?: string | Iterable<[string, string]> | Record): URLSearchParams; }; /** diff --git a/baselines/serviceworker.generated.d.ts b/baselines/serviceworker.generated.d.ts index 6430a4b66..0f9cb029b 100644 --- a/baselines/serviceworker.generated.d.ts +++ b/baselines/serviceworker.generated.d.ts @@ -7794,7 +7794,7 @@ interface URLSearchParams { declare var URLSearchParams: { prototype: URLSearchParams; - new(init?: string[][] | Record | string | URLSearchParams): URLSearchParams; + new(init?: string | Iterable<[string, string]> | Record): URLSearchParams; }; /** diff --git a/baselines/sharedworker.generated.d.ts b/baselines/sharedworker.generated.d.ts index 6ce6e8fb6..51ac35005 100644 --- a/baselines/sharedworker.generated.d.ts +++ b/baselines/sharedworker.generated.d.ts @@ -7337,7 +7337,7 @@ interface URLSearchParams { declare var URLSearchParams: { prototype: URLSearchParams; - new(init?: string[][] | Record | string | URLSearchParams): URLSearchParams; + new(init?: string | Iterable<[string, string]> | Record): URLSearchParams; }; /** diff --git a/baselines/ts5.5/audioworklet.generated.d.ts b/baselines/ts5.5/audioworklet.generated.d.ts index 9b946e70a..3e70659b6 100644 --- a/baselines/ts5.5/audioworklet.generated.d.ts +++ b/baselines/ts5.5/audioworklet.generated.d.ts @@ -1396,7 +1396,7 @@ interface URLSearchParams { declare var URLSearchParams: { prototype: URLSearchParams; - new(init?: string[][] | Record | string | URLSearchParams): URLSearchParams; + new(init?: string | Iterable<[string, string]> | Record): URLSearchParams; }; /** diff --git a/baselines/ts5.5/dom.generated.d.ts b/baselines/ts5.5/dom.generated.d.ts index 5fc97c13e..8791da2bd 100644 --- a/baselines/ts5.5/dom.generated.d.ts +++ b/baselines/ts5.5/dom.generated.d.ts @@ -33164,7 +33164,7 @@ interface URLSearchParams { declare var URLSearchParams: { prototype: URLSearchParams; - new(init?: string[][] | Record | string | URLSearchParams): URLSearchParams; + new(init?: string | Iterable<[string, string]> | Record): URLSearchParams; }; /** diff --git a/baselines/ts5.5/serviceworker.generated.d.ts b/baselines/ts5.5/serviceworker.generated.d.ts index 6847b2bec..5bc5898a4 100644 --- a/baselines/ts5.5/serviceworker.generated.d.ts +++ b/baselines/ts5.5/serviceworker.generated.d.ts @@ -7794,7 +7794,7 @@ interface URLSearchParams { declare var URLSearchParams: { prototype: URLSearchParams; - new(init?: string[][] | Record | string | URLSearchParams): URLSearchParams; + new(init?: string | Iterable<[string, string]> | Record): URLSearchParams; }; /** diff --git a/baselines/ts5.5/sharedworker.generated.d.ts b/baselines/ts5.5/sharedworker.generated.d.ts index de00fa37c..14949118e 100644 --- a/baselines/ts5.5/sharedworker.generated.d.ts +++ b/baselines/ts5.5/sharedworker.generated.d.ts @@ -7337,7 +7337,7 @@ interface URLSearchParams { declare var URLSearchParams: { prototype: URLSearchParams; - new(init?: string[][] | Record | string | URLSearchParams): URLSearchParams; + new(init?: string | Iterable<[string, string]> | Record): URLSearchParams; }; /** diff --git a/baselines/ts5.5/webworker.generated.d.ts b/baselines/ts5.5/webworker.generated.d.ts index cdaec1532..7967b5460 100644 --- a/baselines/ts5.5/webworker.generated.d.ts +++ b/baselines/ts5.5/webworker.generated.d.ts @@ -8943,7 +8943,7 @@ interface URLSearchParams { declare var URLSearchParams: { prototype: URLSearchParams; - new(init?: string[][] | Record | string | URLSearchParams): URLSearchParams; + new(init?: string | Iterable<[string, string]> | Record): URLSearchParams; }; /** diff --git a/baselines/ts5.6/audioworklet.generated.d.ts b/baselines/ts5.6/audioworklet.generated.d.ts index 9b946e70a..3e70659b6 100644 --- a/baselines/ts5.6/audioworklet.generated.d.ts +++ b/baselines/ts5.6/audioworklet.generated.d.ts @@ -1396,7 +1396,7 @@ interface URLSearchParams { declare var URLSearchParams: { prototype: URLSearchParams; - new(init?: string[][] | Record | string | URLSearchParams): URLSearchParams; + new(init?: string | Iterable<[string, string]> | Record): URLSearchParams; }; /** diff --git a/baselines/ts5.6/dom.generated.d.ts b/baselines/ts5.6/dom.generated.d.ts index 7412dce9d..f65edf5b5 100644 --- a/baselines/ts5.6/dom.generated.d.ts +++ b/baselines/ts5.6/dom.generated.d.ts @@ -33187,7 +33187,7 @@ interface URLSearchParams { declare var URLSearchParams: { prototype: URLSearchParams; - new(init?: string[][] | Record | string | URLSearchParams): URLSearchParams; + new(init?: string | Iterable<[string, string]> | Record): URLSearchParams; }; /** diff --git a/baselines/ts5.6/serviceworker.generated.d.ts b/baselines/ts5.6/serviceworker.generated.d.ts index 6847b2bec..5bc5898a4 100644 --- a/baselines/ts5.6/serviceworker.generated.d.ts +++ b/baselines/ts5.6/serviceworker.generated.d.ts @@ -7794,7 +7794,7 @@ interface URLSearchParams { declare var URLSearchParams: { prototype: URLSearchParams; - new(init?: string[][] | Record | string | URLSearchParams): URLSearchParams; + new(init?: string | Iterable<[string, string]> | Record): URLSearchParams; }; /** diff --git a/baselines/ts5.6/sharedworker.generated.d.ts b/baselines/ts5.6/sharedworker.generated.d.ts index de00fa37c..14949118e 100644 --- a/baselines/ts5.6/sharedworker.generated.d.ts +++ b/baselines/ts5.6/sharedworker.generated.d.ts @@ -7337,7 +7337,7 @@ interface URLSearchParams { declare var URLSearchParams: { prototype: URLSearchParams; - new(init?: string[][] | Record | string | URLSearchParams): URLSearchParams; + new(init?: string | Iterable<[string, string]> | Record): URLSearchParams; }; /** diff --git a/baselines/ts5.6/webworker.generated.d.ts b/baselines/ts5.6/webworker.generated.d.ts index cdaec1532..7967b5460 100644 --- a/baselines/ts5.6/webworker.generated.d.ts +++ b/baselines/ts5.6/webworker.generated.d.ts @@ -8943,7 +8943,7 @@ interface URLSearchParams { declare var URLSearchParams: { prototype: URLSearchParams; - new(init?: string[][] | Record | string | URLSearchParams): URLSearchParams; + new(init?: string | Iterable<[string, string]> | Record): URLSearchParams; }; /** diff --git a/baselines/webworker.generated.d.ts b/baselines/webworker.generated.d.ts index 800f6b628..a03d40918 100644 --- a/baselines/webworker.generated.d.ts +++ b/baselines/webworker.generated.d.ts @@ -8943,7 +8943,7 @@ interface URLSearchParams { declare var URLSearchParams: { prototype: URLSearchParams; - new(init?: string[][] | Record | string | URLSearchParams): URLSearchParams; + new(init?: string | Iterable<[string, string]> | Record): URLSearchParams; }; /**