Update LKG.

DanielRosenwasser · DanielRosenwasser · commit cda54b83dc81 · 2020-01-23T10:12:55.000-08:00
diff --git a/lib/tsc.js b/lib/tsc.js
@@ -67,7 +67,7 @@ var __makeTemplateObject = (this && this.__makeTemplateObject) || function (cook
 var ts;
 (function (ts) {
     ts.versionMajorMinor = "3.6";
-    ts.version = ts.versionMajorMinor + ".4";
+    ts.version = ts.versionMajorMinor + ".5";
 })(ts || (ts = {}));
 (function (ts) {
     ts.emptyArray = [];
@@ -30808,8 +30808,10 @@ var ts;
                             }
                         }
                         else {
-                            ts.Debug.assert(!!getter, "there must existed getter as we are current checking either setter or getter in this function");
-                            errorOrSuggestion(noImplicitAny, getter, ts.Diagnostics.Property_0_implicitly_has_type_any_because_its_get_accessor_lacks_a_return_type_annotation, symbolToString(symbol));
+                            ts.Debug.assert(!!getter, "there must exist a getter as we are current checking either setter or getter in this function");
+                            if (!isPrivateWithinAmbient(getter)) {
+                                errorOrSuggestion(noImplicitAny, getter, ts.Diagnostics.Property_0_implicitly_has_type_any_because_its_get_accessor_lacks_a_return_type_annotation, symbolToString(symbol));
+                            }
                         }
                         type = anyType;
                     }
diff --git a/lib/tsserver.js b/lib/tsserver.js
@@ -94,7 +94,7 @@ var ts;
     // If changing the text in this section, be sure to test `configureNightly` too.
     ts.versionMajorMinor = "3.6";
     /** The version of the TypeScript compiler release */
-    ts.version = ts.versionMajorMinor + ".4";
+    ts.version = ts.versionMajorMinor + ".5";
 })(ts || (ts = {}));
 (function (ts) {
     /* @internal */
@@ -37329,8 +37329,10 @@ var ts;
                             }
                         }
                         else {
-                            ts.Debug.assert(!!getter, "there must existed getter as we are current checking either setter or getter in this function");
-                            errorOrSuggestion(noImplicitAny, getter, ts.Diagnostics.Property_0_implicitly_has_type_any_because_its_get_accessor_lacks_a_return_type_annotation, symbolToString(symbol));
+                            ts.Debug.assert(!!getter, "there must exist a getter as we are current checking either setter or getter in this function");
+                            if (!isPrivateWithinAmbient(getter)) {
+                                errorOrSuggestion(noImplicitAny, getter, ts.Diagnostics.Property_0_implicitly_has_type_any_because_its_get_accessor_lacks_a_return_type_annotation, symbolToString(symbol));
+                            }
                         }
                         type = anyType;
                     }
diff --git a/lib/tsserverlibrary.js b/lib/tsserverlibrary.js
@@ -93,7 +93,7 @@ var ts;
     // If changing the text in this section, be sure to test `configureNightly` too.
     ts.versionMajorMinor = "3.6";
     /** The version of the TypeScript compiler release */
-    ts.version = ts.versionMajorMinor + ".4";
+    ts.version = ts.versionMajorMinor + ".5";
 })(ts || (ts = {}));
 (function (ts) {
     /* @internal */
@@ -37328,8 +37328,10 @@ var ts;
                             }
                         }
                         else {
-                            ts.Debug.assert(!!getter, "there must existed getter as we are current checking either setter or getter in this function");
-                            errorOrSuggestion(noImplicitAny, getter, ts.Diagnostics.Property_0_implicitly_has_type_any_because_its_get_accessor_lacks_a_return_type_annotation, symbolToString(symbol));
+                            ts.Debug.assert(!!getter, "there must exist a getter as we are current checking either setter or getter in this function");
+                            if (!isPrivateWithinAmbient(getter)) {
+                                errorOrSuggestion(noImplicitAny, getter, ts.Diagnostics.Property_0_implicitly_has_type_any_because_its_get_accessor_lacks_a_return_type_annotation, symbolToString(symbol));
+                            }
                         }
                         type = anyType;
                     }
diff --git a/lib/typescript.js b/lib/typescript.js
@@ -82,7 +82,7 @@ var ts;
     // If changing the text in this section, be sure to test `configureNightly` too.
     ts.versionMajorMinor = "3.6";
     /** The version of the TypeScript compiler release */
-    ts.version = ts.versionMajorMinor + ".4";
+    ts.version = ts.versionMajorMinor + ".5";
 })(ts || (ts = {}));
 (function (ts) {
     /* @internal */
@@ -37317,8 +37317,10 @@ var ts;
                             }
                         }
                         else {
-                            ts.Debug.assert(!!getter, "there must existed getter as we are current checking either setter or getter in this function");
-                            errorOrSuggestion(noImplicitAny, getter, ts.Diagnostics.Property_0_implicitly_has_type_any_because_its_get_accessor_lacks_a_return_type_annotation, symbolToString(symbol));
+                            ts.Debug.assert(!!getter, "there must exist a getter as we are current checking either setter or getter in this function");
+                            if (!isPrivateWithinAmbient(getter)) {
+                                errorOrSuggestion(noImplicitAny, getter, ts.Diagnostics.Property_0_implicitly_has_type_any_because_its_get_accessor_lacks_a_return_type_annotation, symbolToString(symbol));
+                            }
                         }
                         type = anyType;
                     }
diff --git a/lib/typescriptServices.js b/lib/typescriptServices.js
@@ -82,7 +82,7 @@ var ts;
     // If changing the text in this section, be sure to test `configureNightly` too.
     ts.versionMajorMinor = "3.6";
     /** The version of the TypeScript compiler release */
-    ts.version = ts.versionMajorMinor + ".4";
+    ts.version = ts.versionMajorMinor + ".5";
 })(ts || (ts = {}));
 (function (ts) {
     /* @internal */
@@ -37317,8 +37317,10 @@ var ts;
                             }
                         }
                         else {
-                            ts.Debug.assert(!!getter, "there must existed getter as we are current checking either setter or getter in this function");
-                            errorOrSuggestion(noImplicitAny, getter, ts.Diagnostics.Property_0_implicitly_has_type_any_because_its_get_accessor_lacks_a_return_type_annotation, symbolToString(symbol));
+                            ts.Debug.assert(!!getter, "there must exist a getter as we are current checking either setter or getter in this function");
+                            if (!isPrivateWithinAmbient(getter)) {
+                                errorOrSuggestion(noImplicitAny, getter, ts.Diagnostics.Property_0_implicitly_has_type_any_because_its_get_accessor_lacks_a_return_type_annotation, symbolToString(symbol));
+                            }
                         }
                         type = anyType;
                     }
diff --git a/lib/typingsInstaller.js b/lib/typingsInstaller.js
@@ -83,7 +83,7 @@ var ts;
     // If changing the text in this section, be sure to test `configureNightly` too.
     ts.versionMajorMinor = "3.6";
     /** The version of the TypeScript compiler release */
-    ts.version = ts.versionMajorMinor + ".4";
+    ts.version = ts.versionMajorMinor + ".5";
 })(ts || (ts = {}));
 (function (ts) {
     /* @internal */
@@ -37318,8 +37318,10 @@ var ts;
                             }
                         }
                         else {
-                            ts.Debug.assert(!!getter, "there must existed getter as we are current checking either setter or getter in this function");
-                            errorOrSuggestion(noImplicitAny, getter, ts.Diagnostics.Property_0_implicitly_has_type_any_because_its_get_accessor_lacks_a_return_type_annotation, symbolToString(symbol));
+                            ts.Debug.assert(!!getter, "there must exist a getter as we are current checking either setter or getter in this function");
+                            if (!isPrivateWithinAmbient(getter)) {
+                                errorOrSuggestion(noImplicitAny, getter, ts.Diagnostics.Property_0_implicitly_has_type_any_because_its_get_accessor_lacks_a_return_type_annotation, symbolToString(symbol));
+                            }
                         }
                         type = anyType;
                     }

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ var __makeTemplateObject = (this && this.__makeTemplateObject) \|\| function (cook`
`67`	`67`	`var ts;`
`68`	`68`	`(function (ts) {`
`69`	`69`	`ts.versionMajorMinor = "3.6";`
`70`		`- ts.version = ts.versionMajorMinor + ".4";`
	`70`	`+ ts.version = ts.versionMajorMinor + ".5";`
`71`	`71`	`})(ts \|\| (ts = {}));`
`72`	`72`	`(function (ts) {`
`73`	`73`	`ts.emptyArray = [];`
`@@ -30808,8 +30808,10 @@ var ts;`
`30808`	`30808`	`}`
`30809`	`30809`	`}`
`30810`	`30810`	`else {`
`30811`		`- ts.Debug.assert(!!getter, "there must existed getter as we are current checking either setter or getter in this function");`
`30812`		`- errorOrSuggestion(noImplicitAny, getter, ts.Diagnostics.Property_0_implicitly_has_type_any_because_its_get_accessor_lacks_a_return_type_annotation, symbolToString(symbol));`
	`30811`	`+ ts.Debug.assert(!!getter, "there must exist a getter as we are current checking either setter or getter in this function");`
	`30812`	`+ if (!isPrivateWithinAmbient(getter)) {`
	`30813`	`+ errorOrSuggestion(noImplicitAny, getter, ts.Diagnostics.Property_0_implicitly_has_type_any_because_its_get_accessor_lacks_a_return_type_annotation, symbolToString(symbol));`
	`30814`	`+ }`
`30813`	`30815`	`}`
`30814`	`30816`	`type = anyType;`
`30815`	`30817`	`}`
Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,7 @@ var ts;`
`94`	`94`	// If changing the text in this section, be sure to test `configureNightly` too.
`95`	`95`	`ts.versionMajorMinor = "3.6";`
`96`	`96`	`/** The version of the TypeScript compiler release */`
`97`		`- ts.version = ts.versionMajorMinor + ".4";`
	`97`	`+ ts.version = ts.versionMajorMinor + ".5";`
`98`	`98`	`})(ts \|\| (ts = {}));`
`99`	`99`	`(function (ts) {`
`100`	`100`	`/* @internal */`
`@@ -37329,8 +37329,10 @@ var ts;`
`37329`	`37329`	`}`
`37330`	`37330`	`}`
`37331`	`37331`	`else {`
`37332`		`- ts.Debug.assert(!!getter, "there must existed getter as we are current checking either setter or getter in this function");`
`37333`		`- errorOrSuggestion(noImplicitAny, getter, ts.Diagnostics.Property_0_implicitly_has_type_any_because_its_get_accessor_lacks_a_return_type_annotation, symbolToString(symbol));`
	`37332`	`+ ts.Debug.assert(!!getter, "there must exist a getter as we are current checking either setter or getter in this function");`
	`37333`	`+ if (!isPrivateWithinAmbient(getter)) {`
	`37334`	`+ errorOrSuggestion(noImplicitAny, getter, ts.Diagnostics.Property_0_implicitly_has_type_any_because_its_get_accessor_lacks_a_return_type_annotation, symbolToString(symbol));`
	`37335`	`+ }`
`37334`	`37336`	`}`
`37335`	`37337`	`type = anyType;`
`37336`	`37338`	`}`
Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,7 @@ var ts;`
`93`	`93`	// If changing the text in this section, be sure to test `configureNightly` too.
`94`	`94`	`ts.versionMajorMinor = "3.6";`
`95`	`95`	`/** The version of the TypeScript compiler release */`
`96`		`- ts.version = ts.versionMajorMinor + ".4";`
	`96`	`+ ts.version = ts.versionMajorMinor + ".5";`
`97`	`97`	`})(ts \|\| (ts = {}));`
`98`	`98`	`(function (ts) {`
`99`	`99`	`/* @internal */`
`@@ -37328,8 +37328,10 @@ var ts;`
`37328`	`37328`	`}`
`37329`	`37329`	`}`
`37330`	`37330`	`else {`
`37331`		`- ts.Debug.assert(!!getter, "there must existed getter as we are current checking either setter or getter in this function");`
`37332`		`- errorOrSuggestion(noImplicitAny, getter, ts.Diagnostics.Property_0_implicitly_has_type_any_because_its_get_accessor_lacks_a_return_type_annotation, symbolToString(symbol));`
	`37331`	`+ ts.Debug.assert(!!getter, "there must exist a getter as we are current checking either setter or getter in this function");`
	`37332`	`+ if (!isPrivateWithinAmbient(getter)) {`
	`37333`	`+ errorOrSuggestion(noImplicitAny, getter, ts.Diagnostics.Property_0_implicitly_has_type_any_because_its_get_accessor_lacks_a_return_type_annotation, symbolToString(symbol));`
	`37334`	`+ }`
`37333`	`37335`	`}`
`37334`	`37336`	`type = anyType;`
`37335`	`37337`	`}`
Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,7 @@ var ts;`
`82`	`82`	// If changing the text in this section, be sure to test `configureNightly` too.
`83`	`83`	`ts.versionMajorMinor = "3.6";`
`84`	`84`	`/** The version of the TypeScript compiler release */`
`85`		`- ts.version = ts.versionMajorMinor + ".4";`
	`85`	`+ ts.version = ts.versionMajorMinor + ".5";`
`86`	`86`	`})(ts \|\| (ts = {}));`
`87`	`87`	`(function (ts) {`
`88`	`88`	`/* @internal */`
`@@ -37317,8 +37317,10 @@ var ts;`
`37317`	`37317`	`}`
`37318`	`37318`	`}`
`37319`	`37319`	`else {`
`37320`		`- ts.Debug.assert(!!getter, "there must existed getter as we are current checking either setter or getter in this function");`
`37321`		`- errorOrSuggestion(noImplicitAny, getter, ts.Diagnostics.Property_0_implicitly_has_type_any_because_its_get_accessor_lacks_a_return_type_annotation, symbolToString(symbol));`
	`37320`	`+ ts.Debug.assert(!!getter, "there must exist a getter as we are current checking either setter or getter in this function");`
	`37321`	`+ if (!isPrivateWithinAmbient(getter)) {`
	`37322`	`+ errorOrSuggestion(noImplicitAny, getter, ts.Diagnostics.Property_0_implicitly_has_type_any_because_its_get_accessor_lacks_a_return_type_annotation, symbolToString(symbol));`
	`37323`	`+ }`
`37322`	`37324`	`}`
`37323`	`37325`	`type = anyType;`
`37324`	`37326`	`}`
Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ var ts;`
`83`	`83`	// If changing the text in this section, be sure to test `configureNightly` too.
`84`	`84`	`ts.versionMajorMinor = "3.6";`
`85`	`85`	`/** The version of the TypeScript compiler release */`
`86`		`- ts.version = ts.versionMajorMinor + ".4";`
	`86`	`+ ts.version = ts.versionMajorMinor + ".5";`
`87`	`87`	`})(ts \|\| (ts = {}));`
`88`	`88`	`(function (ts) {`
`89`	`89`	`/* @internal */`
`@@ -37318,8 +37318,10 @@ var ts;`
`37318`	`37318`	`}`
`37319`	`37319`	`}`
`37320`	`37320`	`else {`
`37321`		`- ts.Debug.assert(!!getter, "there must existed getter as we are current checking either setter or getter in this function");`
`37322`		`- errorOrSuggestion(noImplicitAny, getter, ts.Diagnostics.Property_0_implicitly_has_type_any_because_its_get_accessor_lacks_a_return_type_annotation, symbolToString(symbol));`
	`37321`	`+ ts.Debug.assert(!!getter, "there must exist a getter as we are current checking either setter or getter in this function");`
	`37322`	`+ if (!isPrivateWithinAmbient(getter)) {`
	`37323`	`+ errorOrSuggestion(noImplicitAny, getter, ts.Diagnostics.Property_0_implicitly_has_type_any_because_its_get_accessor_lacks_a_return_type_annotation, symbolToString(symbol));`
	`37324`	`+ }`
`37323`	`37325`	`}`
`37324`	`37326`	`type = anyType;`
`37325`	`37327`	`}`