-
Notifications
You must be signed in to change notification settings - Fork 646
.NET: IHostedAgentBuilder overloads for workflows; simplify workflow extensions
#1731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DeagleGross
wants to merge
2
commits into
main
Choose a base branch
from
dmkorolev/cleanup-workflows
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,7 +20,7 @@ | |
| // Configure the chat model and our agent. | ||
| builder.AddKeyedChatClient("chat-model"); | ||
|
|
||
| builder.AddAIAgent( | ||
| var pirateAgent = builder.AddAIAgent( | ||
| "pirate", | ||
| instructions: "You are a pirate. Speak like a pirate", | ||
| description: "An agent that speaks like a pirate.", | ||
|
|
@@ -78,8 +78,20 @@ Once the user has deduced what type (knight or knave) both Alice and Bob are, te | |
| description: "An agent that helps with literature.", | ||
| chatClientServiceKey: "chat-model"); | ||
|
|
||
| builder.AddSequentialWorkflow("science-sequential-workflow", [chemistryAgent, mathsAgent, literatureAgent]).AddAsAIAgent(); | ||
| builder.AddConcurrentWorkflow("science-concurrent-workflow", [chemistryAgent, mathsAgent, literatureAgent]).AddAsAIAgent(); | ||
| var scienceSequentialWorkflow = builder.AddWorkflow("science-sequential-workflow", (sp, key) => | ||
| { | ||
| List<IHostedAgentBuilder> usedAgents = [chemistryAgent, mathsAgent, literatureAgent]; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. FWIW, it's still counterintuitive to me that something called "Agent" and that's returned from a method called "AddAIAgent" is actually a builder. I understand why it is, but maybe there are things we could do to ease this. |
||
| var agents = usedAgents.Select(ab => sp.GetRequiredKeyedService<AIAgent>(ab.Name)); | ||
stephentoub marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| return AgentWorkflowBuilder.BuildSequential(workflowName: key, agents: agents); | ||
| }).AddAsAIAgent(); | ||
|
|
||
| var scienceConcurrentWorkflow = builder.AddWorkflow("science-concurrent-workflow", (sp, key) => | ||
| { | ||
| List<IHostedAgentBuilder> usedAgents = [chemistryAgent, mathsAgent, literatureAgent]; | ||
DeagleGross marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| var agents = usedAgents.Select(ab => sp.GetRequiredKeyedService<AIAgent>(ab.Name)); | ||
DeagleGross marked this conversation as resolved.
Show resolved
Hide resolved
DeagleGross marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| return AgentWorkflowBuilder.BuildConcurrent(workflowName: key, agents: agents); | ||
| }).AddAsAIAgent(); | ||
|
|
||
| builder.AddOpenAIResponses(); | ||
|
|
||
| var app = builder.Build(); | ||
|
|
@@ -91,7 +103,7 @@ Once the user has deduced what type (knight or knave) both Alice and Bob are, te | |
| app.UseExceptionHandler(); | ||
|
|
||
| // attach a2a with simple message communication | ||
| app.MapA2A(agentName: "pirate", path: "/a2a/pirate"); | ||
| app.MapA2A(pirateAgent, path: "/a2a/pirate"); | ||
| app.MapA2A(agentName: "knights-and-knaves", path: "/a2a/knights-and-knaves", agentCard: new() | ||
| { | ||
| Name = "Knights and Knaves", | ||
|
|
@@ -104,8 +116,10 @@ Once the user has deduced what type (knight or knave) both Alice and Bob are, te | |
|
|
||
| app.MapOpenAIResponses(); | ||
|
|
||
| app.MapOpenAIChatCompletions("pirate"); | ||
| app.MapOpenAIChatCompletions(pirateAgent); | ||
| app.MapOpenAIChatCompletions("knights-and-knaves"); | ||
| app.MapOpenAIChatCompletions(scienceSequentialWorkflow); | ||
| app.MapOpenAIChatCompletions(scienceConcurrentWorkflow); | ||
|
|
||
| // Map the agents HTTP endpoints | ||
| app.MapAgentDiscovery("/agents"); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.