Set username and password properly. Don't convert envvars to string (#22)

* Set username and password properly. Don't convert envvars to string. Fixes #20 and #21

Author: ivadim

README.md

@@ -53,7 +53,11 @@ This resource installs and configures the vsts build and release agent
 - `windowslogonpassword`: Set password for windowslogonaccount unless it is equal to NetworkService or LocalService
 - `vsts_url`: url to VSTS instance
 - `vsts_pool`: A pool to connect an agent
-- `vsts_auth`:  Authentication type. Valid options are PAT (Personal Access Token), Negotiate (Kerberos or NTLM), Integrated (Windows default credentials) and ALT (Alternate Credentials). Default PAT auth
+- `vsts_auth`: Authentication type. Default PAT auth. Valid options are:
+  * PAT - Personal Access Token (requires vsts_token),
+  * Negotiate - Kerberos or NTLM (requires vsts_username and vsts_password),
+  * ALT - Alternate Credentials (requires vsts_username and vsts_password),
+  * Integrated - Windows default credentials (doesn't require any credentials).
 - `vsts_token`: A personal access token for VSTS. Used with PAT auth type. [See](http://roadtoalm.com/2015/07/22/using-personal-access-tokens-to-access-visual-studio-online/)
 - `vsts_username`: A user to connect to VSTS. Used with Negotiate and ALT auth
 - `vsts_password`: A user to connect to VSTS. Used with Negotiate and ALT auth

libraries/helpers.rb

@@ -65,12 +65,12 @@ def remove_current_state(agent_name)
       end
 
       def set_auth(args, resource)
-        args['auth'] = resource.vsts_auth
-        if resource.vsts_auth == 'PAT'
+        args['auth'] = resource.vsts_auth.downcase
+        if args['auth'] == 'pat'
           args['token'] = resource.vsts_token
-        elsif (resource.vsts_auth == 'Negotiate') || (resource.vsts_auth == 'ALT')
-          args['--username'] = resource.vsts_username
-          args['--password'] = resource.vsts_password
+        elsif (args['auth'] == 'negotiate') || (args['auth'] == 'alt')
+          args['username'] = resource.vsts_username
+          args['password'] = resource.vsts_password
         end
       end
 

libraries/service.rb

@@ -78,7 +78,7 @@ def vsts_unix_service(action)
         if osx?
           execute.user(@user)
           execute.group(@group)
-          execute.environment(envvars.to_s)
+          execute.environment(envvars)
         end
         execute.run_action(:run)
       end

metadata.rb

@@ -7,7 +7,7 @@
 source_url       'https://github.com/Microsoft/vsts-agent-cookbook' if respond_to?(:source_url)
 issues_url       'https://github.com/Microsoft/vsts-agent-cookbook/issues' if respond_to?(:issues_url)
 chef_version     '>= 12.4' if respond_to?(:chef_version)
-version          '2.0.0'
+version          '2.0.1'
 
 %w(ubuntu debian redhat centos mac_os_x windows).each do |operating_system|
   supports operating_system