-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix(react-tree): TreeItemLayout to use display: grid in order to match TreeItemPersonaLayout's behavior with interior flex boxes
#35387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mindlessroman
wants to merge
4
commits into
microsoft:master
Choose a base branch
from
mindlessroman:mindlessroman/fix-treeitemlayout-width
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size reportUnchanged fixtures
|
|
Pull request demo site: URL |
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/Charts-DonutChart 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Charts-DonutChart.Dynamic - RTL.default.chromium.png | 30793 | Changed |
| vr-tests-react-components/Charts-DonutChart.Dynamic.default.chromium.png | 27053 | Changed |
| vr-tests-react-components/Charts-DonutChart.Dynamic - Dark Mode.default.chromium.png | 12635 | Changed |
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 129 | Changed |
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 488 | Changed |
vr-tests-react-components/Tree 15 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Tree.flat tree multi selection - High Contrast.flat tree multi selection selected 1-1.chromium.png | 786 | Changed |
| vr-tests-react-components/Tree.flat tree multi selection - Dark Mode.flat tree multi selection selected 1-1.chromium.png | 465 | Changed |
| vr-tests-react-components/Tree.flat tree multi selection.flat tree multi selection selected 1-1.chromium.png | 501 | Changed |
| vr-tests-react-components/Tree.flat tree single selection - High Contrast.chromium.png | 671 | Changed |
| vr-tests-react-components/Tree.flat tree single selection - Dark Mode.flat tree single selection selected 1.chromium.png | 413 | Changed |
| vr-tests-react-components/Tree.flat tree single selection - High Contrast.flat tree single selection selected 1.chromium.png | 568 | Changed |
| vr-tests-react-components/Tree.flat tree single selection - Dark Mode.chromium.png | 405 | Changed |
| vr-tests-react-components/Tree.flat tree single selection - RTL.chromium_1.png | 437 | Changed |
| vr-tests-react-components/Tree.flat tree single selection - RTL.flat tree single selection selected 1.chromium_2.png | 437 | Changed |
| vr-tests-react-components/Tree.flat tree single selection.flat tree single selection selected 1.chromium.png | 429 | Changed |
| vr-tests-react-components/Tree.flat tree single selection.chromium.png | 431 | Changed |
| vr-tests-react-components/Tree.layout - Dark Mode.default.chromium.png | 26284 | Changed |
| vr-tests-react-components/Tree.layout - RTL.default.chromium.png | 1171 | Changed |
| vr-tests-react-components/Tree.layout - High Contrast.default.chromium.png | 31683 | Changed |
| vr-tests-react-components/Tree.layout.default.chromium.png | 1177 | Changed |
There were 5 duplicate changes discarded. Check the build logs for more information.
TreeItemLayout to use display: grid in order to match TreeItemPersonaLayout's behavior with interior flex boxesTreeItemLayout to use display: grid in order to match TreeItemPersonaLayout's behavior with interior flex boxes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


masterbranchyarn changelocallyPrevious Behavior
Considering the following code in the stackblitz: https://stackblitz.com/edit/t9nbn2cb?file=src%2Fexample.tsx
Despite having the same CSS insides
The div inside
TreeItemLayoutwas shrunken and wouldn't render in the same way asTreeItemPersonaLayout.New Behavior
When provided the same kind of insides, now flex box divs are rendering the same way, both for regular and flat trees.
Regular:

Flat:

Also rearranging the order of styles in TreeItemPersonaLayout so that they better match regular so that a visual diff is slightly easier.
Testing: I primarily did a visual inspection since it was a challenge to write the right test for a CSS change like this. (hence the colors)
Related Issue(s)