Fixes

Author: mxschmitt

packages/playwright-core/src/server/browserType.ts

@@ -211,7 +211,7 @@ export abstract class BrowserType extends SdkObject {
       command: prepared.executable,
       args: prepared.browserArguments,
       env: {
-        ...await this.amendEnvironment(env, prepared.userDataDir, isPersistent),
+        ...await this.amendEnvironment(env, options, prepared.userDataDir, isPersistent),
         ...await processLifecycleHooks?.envProvider(),
       },
       handleSIGINT,
@@ -337,7 +337,7 @@ export abstract class BrowserType extends SdkObject {
 
   abstract defaultArgs(options: types.LaunchOptions, isPersistent: boolean, userDataDir: string): Promise<string[]>;
   abstract connectToTransport(transport: ConnectionTransport, options: BrowserOptions, browserLogsCollector: RecentLogsCollector): Promise<Browser>;
-  abstract amendEnvironment(env: Env, userDataDir: string, isPersistent: boolean): Promise<Env>;
+  abstract amendEnvironment(env: Env, options: types.LaunchOptions, userDataDir: string, isPersistent: boolean): Promise<Env>;
   abstract doRewriteStartupLog(error: ProtocolError): ProtocolError;
   abstract attemptToGracefullyCloseBrowser(transport: ConnectionTransport): void;
   protected processLifecycleHooks(options: types.LaunchOptions): LaunchLifecycleHooks | undefined {

packages/playwright-core/src/server/webkit/webkit.ts

@@ -42,10 +42,10 @@ export class WebKit extends BrowserType {
     return WKBrowser.connect(this.attribution.playwright, transport, options);
   }
 
-  override async amendEnvironment(env: Env, userDataDir: string, isPersistent: boolean): Promise<Env> {
+  override async amendEnvironment(env: Env, options: types.LaunchOptions, userDataDir: string, isPersistent: boolean): Promise<Env> {
     return {
       ...env,
-      CURL_COOKIE_JAR_PATH: process.platform === 'win32' && isPersistent ? await translatePathToWSL(path.join(userDataDir, 'cookiejar.db')) : undefined,
+      CURL_COOKIE_JAR_PATH: process.platform === 'win32' && isPersistent && options.channel !== 'webkit-wsl' ? path.join(userDataDir, 'cookiejar.db') : undefined,
     };
   }
 

tests/library/trace-viewer.spec.ts

@@ -1456,7 +1456,8 @@ test('should remove noscript when javaScriptEnabled is set to true', async ({ br
   await expect(frame.getByText('Enable JavaScript to run this app.')).toBeHidden();
 });
 
-test('should open snapshot in new browser context', async ({ browser, page, runAndTrace, server }) => {
+test('should open snapshot in new browser context', async ({ browser, page, runAndTrace, server, channel }) => {
+  test.skip(channel === 'webkit-wsl');
   const traceViewer = await runAndTrace(async () => {
     await page.goto(server.EMPTY_PAGE);
     await page.setContent('hello');

tests/page/page-goto.spec.ts

@@ -46,8 +46,9 @@ it('should work with file URL with subframes', async ({ page, asset, isAndroid,
   expect(page.frames().length).toBe(3);
 });
 
-it('should use http for no protocol', async ({ page, server, isAndroid }) => {
+it('should use http for no protocol', async ({ page, server, isAndroid, channel }) => {
   it.skip(isAndroid);
+  it.skip(channel === 'webkit-wsl');
 
   await page.goto(server.EMPTY_PAGE.substring('http://'.length));
   expect(page.url()).toBe(server.EMPTY_PAGE);