Debug

Author: mxschmitt

.github/actions/run-test/action.yml

@@ -52,7 +52,7 @@ runs:
         echo "::endgroup::"
       shell: bash
     - name: Allow WSL network access for WSL2
-      if: inputs.browsers-to-install == 'webkit-wsl'
+      if: contains(inputs.browsers-to-install, 'webkit-wsl')
       shell: powershell
       run: |
         $wslAdapter = Get-NetAdapter | Where-Object {$_.Name -like "*WSL*"}

.github/workflows/tests_primary.yml

@@ -34,7 +34,7 @@ jobs:
     - uses: ./.github/actions/run-test
       with:
         node-version: 22
-        browsers-to-install: webkit-wsl
+        browsers-to-install: webkit-wsl chromium
         command: npm run test -- --project=webkit-* --reporter=list
         bot-name: "webkit-wsl-headed"
         flakiness-client-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_CLIENT_ID }}

packages/playwright-core/bin/webkit-wsl-pipe-wrapper.mjs

@@ -32,8 +32,8 @@ const child = spawn(executable, args, {
     stdio: ['inherit', 'inherit', 'inherit', 'pipe', 'pipe']
 });
 
-socket.pipe(child.stdio[3]);
-child.stdio[4].pipe(socket);
+socket.pipe(/** @type {NodeJS.WritableStream} */ (child.stdio[3]));
+/** @type {NodeJS.ReadableStream} */ (child.stdio[4]).pipe(socket);
 
 // Handle cleanup
 socket.on('end', () => child.kill());

packages/playwright-core/src/server/webkit/webkit.ts

@@ -99,7 +99,6 @@ export class WebKit extends BrowserType {
 }
 
 export function translatePathToWSL(path: string): string {
-  console.log('translatePathToWSL', path);
   const result = spawnSync('wsl', ['-d', 'playwright', '--cd', '/home/pwuser', 'wslpath', path.replace(/\\/g, '\\\\')]).stdout.toString().trim();
   return result;
 }

packages/playwright-core/src/server/webkit/wkPage.ts

@@ -39,6 +39,7 @@ import { WKInterceptableRequest, WKRouteImpl } from './wkInterceptableRequest';
 import { WKProvisionalPage } from './wkProvisionalPage';
 import { WKWorkers } from './wkWorkers';
 import { debugLogger } from '../utils/debugLogger';
+import { translatePathToWSL } from './webkit';
 
 import type { Protocol } from './protocol';
 import type { WKBrowserContext } from './wkBrowser';
@@ -49,7 +50,6 @@ import type { JSHandle } from '../javascript';
 import type { InitScript, PageDelegate } from '../page';
 import type { Progress } from '../progress';
 import type * as types from '../types';
-import { translatePathToWSL } from './webkit';
 
 const UTILITY_WORLD_NAME = '__playwright_utility_world__';
 

tests/config/browserTest.ts

@@ -59,18 +59,14 @@ type BrowserTestTestFixtures = PageTestFixtures & {
 
 const test = baseTest.extend<BrowserTestTestFixtures, BrowserTestWorkerFixtures>({
   loopback: [async ({ channel }, use) => {
-    if (!channel)
-      return await use(undefined);
-    if (execSync('wsl -d playwright --cd /home/pwuser wslinfo --networking-mode').includes('nat'))
+    if (channel === 'webkit-wsl' && execSync('wsl -d playwright --cd /home/pwuser wslinfo --networking-mode').includes('nat'))
       return await use(execSync('wsl -d playwright --cd /home/pwuser ip route show', { encoding: 'utf8' }).trim().split('\n').find(line => line.includes('default'))?.split(' ')[2]);
     return await use(undefined);
   }, { scope: 'worker', timeout: 10000 }],
 
-  loopback2: [async ({ channel }, use) => {
-    if (!channel)
-      return await use(undefined);
-    if (execSync('wsl -d playwright --cd /home/pwuser wslinfo --networking-mode').includes('nat'))
-      return await use(execSync('wsl -d playwright --cd /home/pwuser ip route show', { encoding: 'utf8' }).trim().split('\n').find(line => line.includes('default'))?.split(' ')[2]);
+  loopback2: [async ({ channel, loopback }, use) => {
+    if (channel === 'webkit-wsl' && loopback)
+      return await use(`${loopback}.nip.io`);
     return await use(undefined);
   }, { scope: 'worker', timeout: 10000 }],
 

tests/config/proxy.ts

@@ -30,6 +30,7 @@ export class TestProxy {
   readonly HOST: string;
   readonly PORT: number;
   readonly URL: string;
+  readonly HOSTNAME: string;
 
   connectHosts: string[] = [];
   requestUrls: string[] = [];
@@ -39,13 +40,13 @@ export class TestProxy {
   private readonly _sockets = new Set<net.Socket>();
   private _handlers: { event: string, handler: (...args: any[]) => void }[] = [];
 
-  static async create(port: number): Promise<TestProxy> {
-    const proxy = new TestProxy(port);
+  static async create(port: number, loopback: string): Promise<TestProxy> {
+    const proxy = new TestProxy(port, loopback);
     await new Promise<void>(f => proxy._server.listen(port, f));
     return proxy;
   }
 
-  private constructor(port: number) {
+  private constructor(port: number, loopback: string) {
     this.PORT = port;
     this.URL = `http://localhost:${port}`;
     this.HOST = new URL(this.URL).host;

tests/config/serverFixtures.ts

@@ -38,6 +38,7 @@ export type ServerFixtures = {
 
 export const serverFixtures: Fixtures<ServerFixtures, ServerWorkerOptions> = {
   loopback: [undefined, { scope: 'worker', option: true }],
+  loopback2: [undefined, { scope: 'worker', option: true }],
   __servers: [async ({ loopback, loopback2 }, run, workerInfo) => {
     const assetsPath = path.join(__dirname, '..', 'assets');
     const cachedPath = path.join(__dirname, '..', 'assets', 'cached');
@@ -55,7 +56,7 @@ export const serverFixtures: Fixtures<ServerFixtures, ServerWorkerOptions> = {
     await socksServer.listen(socksPort);
 
     const proxyPort = port + 3;
-    const proxyServer = await TestProxy.create(proxyPort);
+    const proxyServer = await TestProxy.create(proxyPort, loopback);
 
     await run({
       asset: (p: string) => path.join(__dirname, '..', 'assets', ...p.split('/')),

tests/library/browsercontext-proxy.spec.ts

@@ -388,19 +388,19 @@ it('should exclude patterns', async ({ contextFactory, server, proxyServer }) =>
   await context.close();
 });
 
-it('should use socks proxy', async ({ contextFactory, socksPort }) => {
+it('should use socks proxy', async ({ contextFactory, loopback, socksPort }) => {
   const context = await contextFactory({
-    proxy: { server: `socks5://localhost:${socksPort}` }
+    proxy: { server: `socks5://${loopback}:${socksPort}` }
   });
   const page = await context.newPage();
   await page.goto('http://non-existent.com');
   expect(await page.title()).toBe('Served by the SOCKS proxy');
   await context.close();
 });
 
-it('should use socks proxy in second page', async ({ contextFactory, socksPort }) => {
+it('should use socks proxy in second page', async ({ contextFactory, loopback, socksPort }) => {
   const context = await contextFactory({
-    proxy: { server: `socks5://localhost:${socksPort}` }
+    proxy: { server: `socks5://${loopback}:${socksPort}` }
   });
 
   const page = await context.newPage();

tests/library/firefox/launcher.spec.ts

@@ -46,7 +46,7 @@ it('should pass firefox user preferences in persistent', async ({ mode, launchPe
   expect(error.message).toContain('NS_ERROR_PROXY_CONNECTION_REFUSED');
 });
 
-it('should support custom firefox policies', async ({ browserType, mode, asset, loopback }, testInfo) => {
+it('should support custom firefox policies', async ({ browserType, mode, asset, loopback, loopback2 }, testInfo) => {
   it.skip(mode.startsWith('service'));
 
   const policies = {
@@ -60,7 +60,7 @@ it('should support custom firefox policies', async ({ browserType, mode, asset,
   await fs.promises.writeFile(policiesPath, JSON.stringify(policies));
 
   const port = 48112;
-  const server = new TestServer(asset(''), port, loopback, {
+  const server = new TestServer(asset(''), port, loopback, loopback2, {
     key: await fs.promises.readFile(asset('client-certificates/client/localhost/localhost.key')),
     cert: await fs.promises.readFile(asset('client-certificates/client/localhost/localhost.pem')),
   });