-
Notifications
You must be signed in to change notification settings - Fork 157
Run program in terminal instead of the debugger #2788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
minestarks
merged 21 commits into
main
from
minestarks/circuit-disable-tracing-vscode-run
Nov 25, 2025
Merged
Run program in terminal instead of the debugger #2788
minestarks
merged 21 commits into
main
from
minestarks/circuit-disable-tracing-vscode-run
Nov 25, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tarks/circuit-source-links
…tarks/circuit-source-links
72b09eb to
337066a
Compare
…sable-tracing-vscode-run
ScottCarda-MS
approved these changes
Nov 20, 2025
Comment on lines
+229
to
+230
| const compilerTimeout = setTimeout(() => { | ||
| worker.terminate(); |
Check notice
Code scanning / devskim
If untrusted data (data from HTTP requests, user submitted files, etc.) is included in an setTimeout statement it can allow an attacker to inject their own code. Note
Review setTimeout for untrusted data
idavis
reviewed
Nov 24, 2025
orpuente-MS
approved these changes
Nov 24, 2025
idavis
reviewed
Nov 24, 2025
idavis
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the "run" command (accessible via the "Run" code lens, the play button in the corner of the editor or the command palette) was simply invoking the debugger without any breakpoints.
The problem with this approach is that the debugger is slow relative to just running a program using the
run()method in the WASM module. With the recent circuit tracing changes, the debugger is getting more heavyweight.This PR decouples the "Run" command from the debugger. Instead, we create a VS Code terminal and direct the program output to that terminal.
As part of this change, I had to make some changes to error reporting, which happens to fix #149 .
The changes in error reporting and console output handling means that there are subtle updates to how Test Explorer and Copilot reports failed programs as well.
See below for a full UX comparison.