Skip to content

Commit e02148a

Browse files
authored
Bump @types/node and @types/webpack-env. (#5132)
* Bump @types/node and @types/webpack-env. * fixup! Bump @types/node and @types/webpack-env.
1 parent c923f02 commit e02148a

File tree

104 files changed

+1043
-881
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

104 files changed

+1043
-881
lines changed

apps/api-extractor/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@
5757
"@types/heft-jest": "1.0.1",
5858
"@types/lodash": "4.14.116",
5959
"@types/minimatch": "3.0.5",
60-
"@types/node": "18.17.15",
60+
"@types/node": "20.17.19",
6161
"@types/resolve": "1.20.2",
6262
"@types/semver": "7.5.0",
6363
"local-eslint-config": "workspace:*"

apps/heft/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@
5353
"@rushstack/heft": "0.68.12",
5454
"@rushstack/heft-node-rig": "2.6.48",
5555
"@types/heft-jest": "1.0.1",
56-
"@types/node": "18.17.15",
56+
"@types/node": "20.17.19",
5757
"@types/watchpack": "2.4.0",
5858
"typescript": "~5.4.2"
5959
}

apps/heft/src/cli/HeftCommandLineParser.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -245,8 +245,9 @@ export class HeftCommandLineParser extends CommandLineParser {
245245
this.globalTerminal.writeErrorLine(error.stack!);
246246
}
247247

248-
if (!process.exitCode || process.exitCode > 0) {
249-
process.exit(process.exitCode);
248+
const exitCode: string | number | undefined = process.exitCode;
249+
if (!exitCode || typeof exitCode !== 'number' || exitCode > 0) {
250+
process.exit(exitCode);
250251
} else {
251252
process.exit(1);
252253
}

apps/rundown/src/launcher.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ class Launcher {
5151
}
5252

5353
public installHook(): void {
54-
const realRequire: NodeJS.Require = moduleApi.Module.prototype.require;
54+
const realRequire: typeof moduleApi.Module.prototype.require = moduleApi.Module.prototype.require;
5555

5656
const importedModules: Set<unknown> = this._importedModules; // for closure
5757
const importedModulePaths: Set<string> = this._importedModulePaths; // for closure

build-tests-samples/heft-node-basic-tutorial/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
"@rushstack/heft-lint-plugin": "workspace:*",
1818
"@rushstack/heft-typescript-plugin": "workspace:*",
1919
"@types/heft-jest": "1.0.1",
20-
"@types/node": "18.17.15",
20+
"@types/node": "20.17.19",
2121
"eslint": "~8.57.0",
2222
"typescript": "~5.4.2"
2323
}

build-tests-samples/heft-node-jest-tutorial/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
"@rushstack/heft-lint-plugin": "workspace:*",
1717
"@rushstack/heft-typescript-plugin": "workspace:*",
1818
"@types/heft-jest": "1.0.1",
19-
"@types/node": "18.17.15",
19+
"@types/node": "20.17.19",
2020
"eslint": "~8.57.0",
2121
"typescript": "~5.4.2"
2222
}

build-tests-samples/heft-node-rig-tutorial/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,6 @@
1515
"@rushstack/heft": "workspace:*",
1616
"@rushstack/heft-node-rig": "workspace:*",
1717
"@types/heft-jest": "1.0.1",
18-
"@types/node": "18.17.15"
18+
"@types/node": "20.17.19"
1919
}
2020
}

build-tests-samples/heft-serverless-stack-tutorial/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
"@serverless-stack/resources": "1.18.4",
2626
"@types/aws-lambda": "8.10.93",
2727
"@types/heft-jest": "1.0.1",
28-
"@types/node": "18.17.15",
28+
"@types/node": "20.17.19",
2929
"aws-cdk-lib": "2.177.0",
3030
"constructs": "~10.0.98",
3131
"eslint": "~8.57.0",

build-tests-samples/heft-storybook-react-tutorial-storykit/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@
2121
"@storybook/react": "~6.4.18",
2222
"@storybook/theming": "~6.4.18",
2323
"@types/heft-jest": "1.0.1",
24-
"@types/node": "18.17.15",
24+
"@types/node": "20.17.19",
2525
"@types/react-dom": "17.0.25",
2626
"@types/react": "17.0.74",
27-
"@types/webpack-env": "1.18.0",
27+
"@types/webpack-env": "1.18.8",
2828
"babel-loader": "~8.2.3",
2929
"css-loader": "~5.2.7",
3030
"jest": "~29.3.1",

build-tests-samples/heft-storybook-react-tutorial/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,10 @@
2828
"@rushstack/webpack4-module-minifier-plugin": "workspace:*",
2929
"@storybook/react": "~6.4.18",
3030
"@types/heft-jest": "1.0.1",
31-
"@types/node": "18.17.15",
31+
"@types/node": "20.17.19",
3232
"@types/react-dom": "17.0.25",
3333
"@types/react": "17.0.74",
34-
"@types/webpack-env": "1.18.0",
34+
"@types/webpack-env": "1.18.8",
3535
"css-loader": "~5.2.7",
3636
"eslint": "~8.57.0",
3737
"heft-storybook-react-tutorial-storykit": "workspace:*",

0 commit comments

Comments
 (0)