From d35ec5980ba286d82ee9c52fc2637a39df154992 Mon Sep 17 00:00:00 2001 From: Farheen Shaikh Date: Thu, 26 Jun 2025 17:55:05 -0700 Subject: [PATCH 1/2] Add option to open parent folder from JSON settings --- .../TestHostApp/TestHostApp.vcxproj | 46 ++++--------------- .../TerminalApp/TerminalAppLib.vcxproj | 6 +-- .../TerminalAppLib.vcxproj.filters | 12 ++--- .../TerminalApp/dll/TerminalApp.vcxproj | 8 ++-- .../TerminalConnection.vcxproj | 2 + .../TerminalControlLib.vcxproj | 2 + .../dll/TerminalControl.vcxproj | 13 ++---- .../TerminalCore/lib/terminalcore-lib.vcxproj | 12 ++--- ...Microsoft.Terminal.Settings.Editor.vcxproj | 2 + ...t.Terminal.Settings.Editor.vcxproj.filters | 4 ++ ...crosoft.Terminal.Settings.ModelLib.vcxproj | 9 ++-- ...Terminal.Settings.ModelLib.vcxproj.filters | 13 ++++-- .../Microsoft.Terminal.Settings.Model.vcxproj | 10 ++-- src/cascadia/UIHelpers/UIHelpers.vcxproj | 4 +- src/cascadia/UIMarkdown/UIMarkdown.vcxproj | 2 + src/cascadia/WinRTUtils/WinRTUtils.vcxproj | 2 + .../RenderingTests/RenderingTests.vcxproj | 4 +- .../RenderingTests.vcxproj.filters | 7 +++ src/tools/benchcat/benchcat.vcxproj | 4 +- 19 files changed, 67 insertions(+), 95 deletions(-) diff --git a/src/cascadia/LocalTests_TerminalApp/TestHostApp/TestHostApp.vcxproj b/src/cascadia/LocalTests_TerminalApp/TestHostApp/TestHostApp.vcxproj index 875fd0a45ae..8aa2bcf49ec 100644 --- a/src/cascadia/LocalTests_TerminalApp/TestHostApp/TestHostApp.vcxproj +++ b/src/cascadia/LocalTests_TerminalApp/TestHostApp/TestHostApp.vcxproj @@ -14,15 +14,14 @@ true Application true - false + false + false - true - false false + 10.0 + 10.0.26100.0 - - - - - false - @@ -71,7 +66,6 @@ false - @@ -96,51 +90,39 @@ Create - {CA5CAD1A-C46D-4588-B1C0-40F31AE9100B} - - {ca5cad1a-44bd-4ac7-ac72-f16e576fdd12} - {CA5CAD1A-082C-4476-9F33-94B339494076} - - <_TAEFPlatformName>$(Platform) <_TAEFPlatformName Condition="'$(Platform)'=='Win32'">x86 - $(TAEFPackagePathRoot)\lib\Microsoft.VisualStudio.TestPlatform.TestExecutor.WinRTCore.winmd true - ..\build\Binaries\$(_TAEFPlatformName)\TE.AppxUnitTestClient.dll - - - - - + - + - - - - + - - + - + \ No newline at end of file diff --git a/src/cascadia/TerminalApp/TerminalAppLib.vcxproj b/src/cascadia/TerminalApp/TerminalAppLib.vcxproj index ac4357554cc..c40d45d573b 100644 --- a/src/cascadia/TerminalApp/TerminalAppLib.vcxproj +++ b/src/cascadia/TerminalApp/TerminalAppLib.vcxproj @@ -21,6 +21,8 @@ We do this so we can delay the Settings UI DLL loading until absolutely necessary. --> DoNotGenerateOtherProviders + 10.0 + 10.0.26100.0 true @@ -314,7 +316,6 @@ MarkdownPaneContent.xaml Code - @@ -445,7 +446,6 @@ true false - true true + 10.0 + 10.0.26100.0 true @@ -81,8 +83,6 @@ true - - - + \ No newline at end of file diff --git a/src/cascadia/TerminalConnection/TerminalConnection.vcxproj b/src/cascadia/TerminalConnection/TerminalConnection.vcxproj index 8eda9937725..e377d8f61f5 100644 --- a/src/cascadia/TerminalConnection/TerminalConnection.vcxproj +++ b/src/cascadia/TerminalConnection/TerminalConnection.vcxproj @@ -8,6 +8,8 @@ Console true true + 10.0 + 10.0.26100.0 true diff --git a/src/cascadia/TerminalControl/TerminalControlLib.vcxproj b/src/cascadia/TerminalControl/TerminalControlLib.vcxproj index 90d053424f9..7d5b74b646c 100644 --- a/src/cascadia/TerminalControl/TerminalControlLib.vcxproj +++ b/src/cascadia/TerminalControl/TerminalControlLib.vcxproj @@ -19,6 +19,8 @@ --> 3 nested + 10.0 + 10.0.26100.0 true diff --git a/src/cascadia/TerminalControl/dll/TerminalControl.vcxproj b/src/cascadia/TerminalControl/dll/TerminalControl.vcxproj index e6cd662dd10..3455252de68 100644 --- a/src/cascadia/TerminalControl/dll/TerminalControl.vcxproj +++ b/src/cascadia/TerminalControl/dll/TerminalControl.vcxproj @@ -11,7 +11,6 @@ true true - 3 + 10.0 + 10.0.26100.0 - true true - @@ -65,13 +64,11 @@ true true - {6515F03F-E56D-4DB4-B23D-AC4FB80DB36F} false - /INCLUDE:_DllMain@12 %(AdditionalOptions) /INCLUDE:DllMain %(AdditionalOptions) - false @@ -111,7 +105,6 @@ - - + \ No newline at end of file diff --git a/src/cascadia/TerminalCore/lib/terminalcore-lib.vcxproj b/src/cascadia/TerminalCore/lib/terminalcore-lib.vcxproj index f1bc1acacdf..dd3d9225116 100644 --- a/src/cascadia/TerminalCore/lib/terminalcore-lib.vcxproj +++ b/src/cascadia/TerminalCore/lib/terminalcore-lib.vcxproj @@ -7,22 +7,19 @@ TerminalCore StaticLibrary Microsoft.Terminal.Core - true + 10.0 + 10.0.26100.0 - true - - - @@ -47,7 +44,6 @@ {3c67784e-1453-49c2-9660-483e2cc7f7ad} - @@ -65,10 +61,8 @@ $(WinRT_IncludePath)\..\cppwinrt\winrt;"$(OpenConsoleDir)src\cascadia\TerminalCore\Generated Files";%(AdditionalIncludeDirectories); - - - + \ No newline at end of file diff --git a/src/cascadia/TerminalSettingsEditor/Microsoft.Terminal.Settings.Editor.vcxproj b/src/cascadia/TerminalSettingsEditor/Microsoft.Terminal.Settings.Editor.vcxproj index da55bbd7571..7186f67455f 100644 --- a/src/cascadia/TerminalSettingsEditor/Microsoft.Terminal.Settings.Editor.vcxproj +++ b/src/cascadia/TerminalSettingsEditor/Microsoft.Terminal.Settings.Editor.vcxproj @@ -31,6 +31,8 @@ --> 4 nested + 10.0 + 10.0.26100.0 true diff --git a/src/cascadia/TerminalSettingsEditor/Microsoft.Terminal.Settings.Editor.vcxproj.filters b/src/cascadia/TerminalSettingsEditor/Microsoft.Terminal.Settings.Editor.vcxproj.filters index 97caa229d14..f065792b949 100644 --- a/src/cascadia/TerminalSettingsEditor/Microsoft.Terminal.Settings.Editor.vcxproj.filters +++ b/src/cascadia/TerminalSettingsEditor/Microsoft.Terminal.Settings.Editor.vcxproj.filters @@ -54,5 +54,9 @@ + + + + \ No newline at end of file diff --git a/src/cascadia/TerminalSettingsModel/Microsoft.Terminal.Settings.ModelLib.vcxproj b/src/cascadia/TerminalSettingsModel/Microsoft.Terminal.Settings.ModelLib.vcxproj index adf1610f5e1..98233e155bf 100644 --- a/src/cascadia/TerminalSettingsModel/Microsoft.Terminal.Settings.ModelLib.vcxproj +++ b/src/cascadia/TerminalSettingsModel/Microsoft.Terminal.Settings.ModelLib.vcxproj @@ -9,6 +9,8 @@ StaticLibrary Console true + 10.0 + 10.0.26100.0 true @@ -258,7 +260,6 @@ {ef3e32a7-5ff6-42b4-b6e2-96cd7d033f00} - - - @@ -333,5 +331,4 @@ - - + \ No newline at end of file diff --git a/src/cascadia/TerminalSettingsModel/Microsoft.Terminal.Settings.ModelLib.vcxproj.filters b/src/cascadia/TerminalSettingsModel/Microsoft.Terminal.Settings.ModelLib.vcxproj.filters index 3933a242819..24bf4cb9565 100644 --- a/src/cascadia/TerminalSettingsModel/Microsoft.Terminal.Settings.ModelLib.vcxproj.filters +++ b/src/cascadia/TerminalSettingsModel/Microsoft.Terminal.Settings.ModelLib.vcxproj.filters @@ -2,6 +2,7 @@ + @@ -96,6 +97,8 @@ + + @@ -115,9 +118,8 @@ - - - + + @@ -127,4 +129,7 @@ {81a6314f-aa5b-4533-a499-13bc3a5c4af0} - + + + + \ No newline at end of file diff --git a/src/cascadia/TerminalSettingsModel/dll/Microsoft.Terminal.Settings.Model.vcxproj b/src/cascadia/TerminalSettingsModel/dll/Microsoft.Terminal.Settings.Model.vcxproj index 6ab7c606893..73bc02287e7 100644 --- a/src/cascadia/TerminalSettingsModel/dll/Microsoft.Terminal.Settings.Model.vcxproj +++ b/src/cascadia/TerminalSettingsModel/dll/Microsoft.Terminal.Settings.Model.vcxproj @@ -11,6 +11,8 @@ true true + 10.0 + 10.0.26100.0 true @@ -89,7 +91,6 @@ false - @@ -106,7 +106,6 @@ true - - + \ No newline at end of file diff --git a/src/cascadia/UIHelpers/UIHelpers.vcxproj b/src/cascadia/UIHelpers/UIHelpers.vcxproj index eaae5b75ac1..662da51b220 100644 --- a/src/cascadia/UIHelpers/UIHelpers.vcxproj +++ b/src/cascadia/UIHelpers/UIHelpers.vcxproj @@ -7,6 +7,8 @@ DynamicLibrary Console true + 10.0 + 10.0.26100.0 true @@ -85,4 +87,4 @@ - + \ No newline at end of file diff --git a/src/cascadia/UIMarkdown/UIMarkdown.vcxproj b/src/cascadia/UIMarkdown/UIMarkdown.vcxproj index c23ec98a879..7629bd4b211 100644 --- a/src/cascadia/UIMarkdown/UIMarkdown.vcxproj +++ b/src/cascadia/UIMarkdown/UIMarkdown.vcxproj @@ -17,6 +17,8 @@ --> 4 nested + 10.0 + 10.0.26100.0 true diff --git a/src/cascadia/WinRTUtils/WinRTUtils.vcxproj b/src/cascadia/WinRTUtils/WinRTUtils.vcxproj index 13052c590be..bbbe7ed9ae4 100644 --- a/src/cascadia/WinRTUtils/WinRTUtils.vcxproj +++ b/src/cascadia/WinRTUtils/WinRTUtils.vcxproj @@ -10,6 +10,8 @@ Console true false + 10.0 + 10.0.26100.0 true diff --git a/src/tools/RenderingTests/RenderingTests.vcxproj b/src/tools/RenderingTests/RenderingTests.vcxproj index 5de14c0f43e..6b60c7f7f6a 100644 --- a/src/tools/RenderingTests/RenderingTests.vcxproj +++ b/src/tools/RenderingTests/RenderingTests.vcxproj @@ -6,7 +6,7 @@ {37c995e0-2349-4154-8e77-4a52c0c7f46d} RenderingTests RenderingTests - 10.0 + 10.0.22621.0 @@ -24,4 +24,4 @@ - + \ No newline at end of file diff --git a/src/tools/RenderingTests/RenderingTests.vcxproj.filters b/src/tools/RenderingTests/RenderingTests.vcxproj.filters index 0f14913f3c7..c151c7dbfd3 100644 --- a/src/tools/RenderingTests/RenderingTests.vcxproj.filters +++ b/src/tools/RenderingTests/RenderingTests.vcxproj.filters @@ -1,4 +1,11 @@  + + + + + + + \ No newline at end of file diff --git a/src/tools/benchcat/benchcat.vcxproj b/src/tools/benchcat/benchcat.vcxproj index 67a51675a14..d56ad33dcf1 100644 --- a/src/tools/benchcat/benchcat.vcxproj +++ b/src/tools/benchcat/benchcat.vcxproj @@ -6,7 +6,7 @@ {2C836962-9543-4CE5-B834-D28E1F124B66} benchcat benchcat - 10.0 + 10.0.22621.0 bc @@ -42,4 +42,4 @@ - + \ No newline at end of file From cba0f367546c28d97a2287b0476bb95cc447bcc6 Mon Sep 17 00:00:00 2001 From: Farheen Shaikh Date: Fri, 27 Jun 2025 00:11:51 -0700 Subject: [PATCH 2/2] Revert unintended vcxproj changes --- .../TestHostApp/TestHostApp.vcxproj | 46 +++++++++++++++---- 1 file changed, 37 insertions(+), 9 deletions(-) diff --git a/src/cascadia/LocalTests_TerminalApp/TestHostApp/TestHostApp.vcxproj b/src/cascadia/LocalTests_TerminalApp/TestHostApp/TestHostApp.vcxproj index 8aa2bcf49ec..875fd0a45ae 100644 --- a/src/cascadia/LocalTests_TerminalApp/TestHostApp/TestHostApp.vcxproj +++ b/src/cascadia/LocalTests_TerminalApp/TestHostApp/TestHostApp.vcxproj @@ -14,14 +14,15 @@ true Application true - false - + false false + true + false false - 10.0 - 10.0.26100.0 + + + + + false + @@ -66,6 +71,7 @@ false + @@ -90,39 +96,51 @@ Create + {CA5CAD1A-C46D-4588-B1C0-40F31AE9100B} + + {ca5cad1a-44bd-4ac7-ac72-f16e576fdd12} + {CA5CAD1A-082C-4476-9F33-94B339494076} + + <_TAEFPlatformName>$(Platform) <_TAEFPlatformName Condition="'$(Platform)'=='Win32'">x86 + $(TAEFPackagePathRoot)\lib\Microsoft.VisualStudio.TestPlatform.TestExecutor.WinRTCore.winmd true + ..\build\Binaries\$(_TAEFPlatformName)\TE.AppxUnitTestClient.dll + + - + + + - + + + - + + - + + - \ No newline at end of file +