add additional metadata for thinking parts (#1395)

* add additional metadata for thinking parts

* fix some comments, rename

* cleanup

Author: justschen

src/extension/conversation/vscode-node/languageModelAccess.ts

@@ -448,7 +448,19 @@ export class CopilotLanguageModelWrapper extends Disposable {
 	}
 
 	async provideLanguageModelResponse(endpoint: IChatEndpoint, messages: Array<vscode.LanguageModelChatMessage | vscode.LanguageModelChatMessage2>, options: vscode.ProvideLanguageModelChatResponseOptions, extensionId: string, progress: vscode.Progress<LMResponsePart>, token: vscode.CancellationToken): Promise<any> {
+		let thinkingActive = false;
 		const finishCallback: FinishedCallback = async (_text, index, delta): Promise<undefined> => {
+			if (delta.thinking) {
+				// Show thinking progress for unencrypted thinking deltas
+				if (!isEncryptedThinkingDelta(delta.thinking)) {
+					const text = delta.thinking.text ?? '';
+					progress.report(new vscode.LanguageModelThinkingPart(text, delta.thinking.id, delta.thinking.metadata));
+					thinkingActive = true;
+				}
+			} else if (thinkingActive) {
+				progress.report(new vscode.LanguageModelThinkingPart('', '', { vscode_reasoning_done: true }));
+				thinkingActive = false;
+			}
 			if (delta.text) {
 				progress.report(new vscode.LanguageModelTextPart(delta.text));
 			}
@@ -463,13 +475,6 @@ export class CopilotLanguageModelWrapper extends Disposable {
 					}
 				}
 			}
-			if (delta.thinking) {
-				// Show thinking progress for unencrypted thinking deltas
-				if (!isEncryptedThinkingDelta(delta.thinking)) {
-					const text = delta.thinking.text ?? '';
-					progress.report(new vscode.LanguageModelThinkingPart(text, delta.thinking.id, delta.thinking.metadata));
-				}
-			}
 
 			if (delta.statefulMarker) {
 				progress.report(

src/extension/prompt/node/pseudoStartStopConversationCallback.ts

@@ -27,6 +27,7 @@ export class PseudoStopStartResponseProcessor implements IResponseProcessor {
 	private stagedDeltasToApply: IResponseDelta[] = [];
 	private currentStartStop: StartStopMapping | undefined = undefined;
 	private nonReportedDeltas: IResponseDelta[] = [];
+	private thinkingActive: boolean = false;
 
 	constructor(
 		private readonly stopStartMappings: readonly StartStopMapping[],
@@ -47,6 +48,17 @@ export class PseudoStopStartResponseProcessor implements IResponseProcessor {
 	}
 
 	protected applyDeltaToProgress(delta: IResponseDelta, progress: ChatResponseStream) {
+		if (delta.thinking) {
+			// Don't send parts that are only encrypted content
+			if (!isEncryptedThinkingDelta(delta.thinking) || delta.thinking.text) {
+				progress.thinkingProgress(delta.thinking);
+				this.thinkingActive = true;
+			}
+		} else if (this.thinkingActive) {
+			progress.thinkingProgress({ id: '', text: '', metadata: { vscode_reasoning_done: true } });
+			this.thinkingActive = false;
+		}
+
 		reportCitations(delta, progress);
 
 		const vulnerabilities: ChatVulnerability[] | undefined = delta.codeVulnAnnotations?.map(a => ({ title: a.details.type, description: a.details.description }));
@@ -59,13 +71,6 @@ export class PseudoStopStartResponseProcessor implements IResponseProcessor {
 		if (delta.beginToolCalls?.length) {
 			progress.prepareToolInvocation(getContributedToolName(delta.beginToolCalls[0].name));
 		}
-
-		if (delta.thinking) {
-			// Don't send parts that are only encrypted content
-			if (!isEncryptedThinkingDelta(delta.thinking) || delta.thinking.text) {
-				progress.thinkingProgress(delta.thinking);
-			}
-		}
 	}
 
 	/**
@@ -155,6 +160,7 @@ export class PseudoStopStartResponseProcessor implements IResponseProcessor {
 			this.stagedDeltasToApply = [];
 			this.currentStartStop = undefined;
 			this.nonReportedDeltas = [];
+			this.thinkingActive = false;
 			if (delta.retryReason === 'network_error') {
 				progress.clearToPreviousToolInvocation(ChatResponseClearToPreviousToolInvocationReason.NoReason);
 			} else if (delta.retryReason === FilterReason.Copyright) {