fix: use WeakMap to map Diagnostic and UpgradeIssue

Author: FluoriteCafe-work

src/upgrade/display/diagnosticsManager.ts

@@ -2,32 +2,38 @@
 // Licensed under the MIT license.
 
 import { Diagnostic, DiagnosticSeverity, type Disposable, languages, Uri, Range } from "vscode";
-import type { FileIssues } from "../type";
+import type { FileIssues, UpgradeIssue } from "../type";
 import { Upgrade } from "../../constants";
 import { buildMessage } from "../utility";
 
 class DiagnosticsManager implements Disposable {
     private diagnostics = languages.createDiagnosticCollection('javaUpgrade');
+    private diagIssueMap = new WeakMap<Diagnostic, UpgradeIssue>();
 
     dispose() {
         this.diagnostics.dispose();
     }
 
-    refresh(filePath: string, issues: FileIssues) {
-        this.diagnostics.set(Uri.file(filePath), Object.entries(issues).map(([groupId, issue]) => {
+    public refresh(filePath: string, issues: FileIssues) {
+        this.diagnostics.set(Uri.file(filePath), Object.entries(issues).map(([packageId, issue]) => {
             const diagnostic = new Diagnostic(
                 // TODO: locate the actual version settings
                 new Range(0, 0, 0, 0),
                 buildMessage(issue),
                 DiagnosticSeverity.Warning
             );
+            this.diagIssueMap.set(diagnostic, issue);
 
-            diagnostic.code = JSON.stringify(issue);
+            diagnostic.code = packageId;
             diagnostic.source = Upgrade.PROMOTION_DIAGNOSTIC_SOURCE;
 
             return diagnostic;
         }));
     }
+
+    public getIssue(diagnostic: Diagnostic) {
+        return this.diagIssueMap.get(diagnostic);
+    }
 }
 
 const diagnosticsManager = new DiagnosticsManager();

src/upgrade/upgradeCodeActionProvider.ts

@@ -5,16 +5,16 @@ import { CancellationToken, CodeAction, CodeActionContext, CodeActionKind, CodeA
 import { Upgrade } from "../constants";
 import { Commands } from "../commands";
 import metadataManager from "./metadataManager";
-import { buildFixPrompt, tryParse } from "./utility";
-import type { UpgradeIssue } from "./type";
+import { buildFixPrompt } from "./utility";
+import diagnosticsManager from "./display/diagnosticsManager";
 
 export default class UpgradeCodeActionProvider implements CodeActionProvider {
     provideCodeActions(_document: TextDocument, _range: Range | Selection, context: CodeActionContext, _token: CancellationToken): ProviderResult<(CodeAction | Command)[]> {
         const actions: CodeAction[] = [];
 
         for (const diagnostic of context.diagnostics) {
             if (diagnostic.source === Upgrade.PROMOTION_DIAGNOSTIC_SOURCE) {
-                const issue = tryParse<UpgradeIssue>(String(diagnostic.code));
+                const issue = diagnosticsManager.getIssue(diagnostic);
                 if (!issue) {
                     return;
                 }

src/upgrade/utility.ts

@@ -38,12 +38,4 @@ export function buildFixPrompt(issue: UpgradeIssue): string {
             return [`Upgrade Java version.`, ...suffix].join(" ");
         }
     }
-}
-
-export function tryParse<T>(x: string): T | undefined {
-    try {
-        return JSON.parse(x)
-    } catch (_) {
-        return undefined
-    }
-}
+}