Skip to content

Commit 10c077b

Browse files
authored
Use --ignore-scripts when running npm ci as done in all other places (#16993)
* Use ` --ignore-scripts` when running npm ci as done in all other places * Updates * Updates * wip * Install playwright
1 parent 0e96cf1 commit 10c077b

File tree

4 files changed

+19
-3
lines changed

4 files changed

+19
-3
lines changed

.github/actions/npm-ci/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ description: 'npm install (with GITHUB_TOKEN to run postinstall step)'
44
runs:
55
using: 'composite'
66
steps:
7-
- run: npm ci --foreground-scripts --prefer-offline
7+
- run: npm ci --foreground-scripts --prefer-offline --ignore-scripts
88
env:
99
npm_config_build_from_source: true
1010
shell: bash

.github/workflows/build-test.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -717,6 +717,10 @@ jobs:
717717
env:
718718
VSC_JUPYTER_CI_TEST_GREP: ${{ matrix.tags }}
719719

720+
- name: Install playwright
721+
run: npx playwright install
722+
if: matrix.python != 'noPython' && matrix.os == 'ubuntu-latest' && matrix.jupyterConnection == 'web'
723+
720724
- name: Run Native Notebook with VSCode & Jupyter (web)
721725
uses: GabrielBB/xvfb-action@b706e4e27b14669b486812790492dc50ca16b465 # v1.7
722726
with:

build/azure-pipeline.pre-release.yml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,12 +73,18 @@ extends:
7373
addToPath: true
7474
architecture: 'x64'
7575

76-
- script: npm ci --foreground-scripts
76+
- script: npm ci --foreground-scripts --ignore-scripts
7777
displayName: npm ci
7878
env:
7979
npm_config_build_from_source: true
8080
VSC_VSCE_TARGET: $(vsceTarget)
8181

82+
- script: npm run postinstall
83+
displayName: npm postinstall
84+
env:
85+
npm_config_build_from_source: true
86+
VSC_VSCE_TARGET: $(vsceTarget)
87+
8288
- script: npm run clean
8389
displayName: Clean
8490

build/azure-pipeline.stable.yml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,12 +67,18 @@ extends:
6767
addToPath: true
6868
architecture: 'x64'
6969

70-
- script: npm ci --foreground-scripts
70+
- script: npm ci --foreground-scripts --ignore-scripts
7171
displayName: npm ci
7272
env:
7373
npm_config_build_from_source: true
7474
VSC_VSCE_TARGET: $(vsceTarget)
7575

76+
- script: npm run postinstall
77+
displayName: npm postinstall
78+
env:
79+
npm_config_build_from_source: true
80+
VSC_VSCE_TARGET: $(vsceTarget)
81+
7682
- script: npm run clean
7783
displayName: Clean
7884

0 commit comments

Comments
 (0)