-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
feat!: cleanup references of --compilers #5403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved but not merging, waiting for Mocha 12 (#5357)
|
noting maybe we should use |
|
Technically this does change the user-facing behavior of Mocha. |
|
haha it's bikeshedding at this point, |
mark-wiemer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests are now failing
|
Tests passed locally after resolving merge conflicts :) will be merging this one tmrw @JoshuaKGoldberg |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5403 +/- ##
==========================================
- Coverage 93.73% 93.68% -0.05%
==========================================
Files 57 57
Lines 4391 4389 -2
Branches 850 849 -1
==========================================
- Hits 4116 4112 -4
- Misses 275 277 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
PR Checklist
status: accepting prsOverview
Removes the last references from the code about --compilers there are still a lot of references in change logs and in documentation but was not sure if those should be removed or not.