Skip to content

Conversation

@samuelhnrq
Copy link
Contributor

PR Checklist

Overview

Removes the last references from the code about --compilers there are still a lot of references in change logs and in documentation but was not sure if those should be removed or not.

@mark-wiemer mark-wiemer added the semver-major implementation requires increase of "major" version number; "breaking changes" label Jul 21, 2025
Copy link
Member

@mark-wiemer mark-wiemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but not merging, waiting for Mocha 12 (#5357)

@JoshuaKGoldberg JoshuaKGoldberg changed the title chore: cleanup references of --compilers feat!: cleanup references of --compilers Oct 1, 2025
@mark-wiemer
Copy link
Member

noting maybe we should use chore! instead to emphasize that this isn't a new feature in Mocha really

@JoshuaKGoldberg
Copy link
Member

Technically this does change the user-facing behavior of Mocha. fix!, then? 😄

@mark-wiemer
Copy link
Member

haha it's bikeshedding at this point, feat! is fine by me

Copy link
Member

@mark-wiemer mark-wiemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are now failing

@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author waiting on response from OP or other posters - more information needed label Oct 2, 2025
@mark-wiemer mark-wiemer self-assigned this Nov 22, 2025
@mark-wiemer mark-wiemer removed the status: waiting for author waiting on response from OP or other posters - more information needed label Nov 22, 2025
@mark-wiemer mark-wiemer added this to the v12.0.0 milestone Nov 22, 2025
@mark-wiemer
Copy link
Member

Tests passed locally after resolving merge conflicts :) will be merging this one tmrw @JoshuaKGoldberg

@codecov
Copy link

codecov bot commented Nov 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.68%. Comparing base (ca4af43) to head (05376fc).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5403      +/-   ##
==========================================
- Coverage   93.73%   93.68%   -0.05%     
==========================================
  Files          57       57              
  Lines        4391     4389       -2     
  Branches      850      849       -1     
==========================================
- Hits         4116     4112       -4     
- Misses        275      277       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mark-wiemer mark-wiemer merged commit f75d150 into mochajs:main Nov 22, 2025
79 of 80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-major implementation requires increase of "major" version number; "breaking changes"

Projects

Development

Successfully merging this pull request may close these issues.

🚀 Feature: Remove the long-deprecated --compilers option

3 participants