fix: prevent potential goroutine leak on blocked incoming channel

cryo-zd · cryo-zd · commit 0f708afd3a46 · 2025-07-11T14:43:23.000Z
diff --git a/mcp/streamable.go b/mcp/streamable.go
@@ -760,7 +760,12 @@ func (s *streamableClientConn) handleSSE(resp *http.Response) {
 				// TODO: surface this error; possibly break the stream
 				return
 			}
-			s.incoming <- evt.data
+
+			select {
+			case s.incoming <- evt.data:
+			case <-s.done:
+				return
+			}
 		}
 	}()
 

Original file line number	Diff line number	Diff line change
`@@ -760,7 +760,12 @@ func (s streamableClientConn) handleSSE(resp http.Response) {`
`760`	`760`	`// TODO: surface this error; possibly break the stream`
`761`	`761`	`return`
`762`	`762`	`}`
`763`		`- s.incoming <- evt.data`
	`763`	`+`
	`764`	`+ select {`
	`765`	`+ case s.incoming <- evt.data:`
	`766`	`+ case <-s.done:`
	`767`	`+ return`
	`768`	`+ }`
`764`	`769`	`}`
`765`	`770`	`}()`
`766`	`771`