Bug fix: a missing type variable ReceiveResultT in the BaseSession class definition. #1034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huangjia2019
changed the title
|
Will someone review this PR? |
felixweinberger
requested changes
Sep 5, 2025
felixweinberger
added
the
needs more work
|
Hi @huangjia2019 closing this PR for now to ensure we prioritize reviews appropriately on our team, feel free to ping here or reopen if you plan to return to this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: a missing type variable ReceiveResultT in the BaseSession class definition.
Motivation and Context
Added ReceiveResultT as a generic type parameter to BaseSession.
This aligns BaseSession's generic signature with its actual method usage, particularly for:
send_request() which returns a ReceiveResultT
_send_response() which also sends a ReceiveResultT in some cases
Why
Without ReceiveResultT in the class signature, type checking tools (like Pyright or MyPy) may raise warnings or fail to infer correct types.
The class was already using ReceiveResultT internally, so this fix improves type completeness and consistency.
Impact
Improves type safety and developer experience for consumers of the MCP Python SDK
How Has This Been Tested?
No behavior change; purely type annotation fix
Breaking Changes
None
Types of changes
Checklist