Skip to content

Conversation

@fluteink
Copy link
Contributor

现在魔搭社区已经由原来的damo转为了通义实验室的"iic",为避免重定向,更新脚本。拼写错误lagre->large

现在魔搭社区已经由原来的damo转为了通义实验室的"iic",为避免重定向,更新脚本。
现在魔搭社区已经由原来的damo转为了通义实验室的"iic",为避免重定向,更新脚本。拼写错误lagre->large
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @fluteink, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

此拉取请求主要更新了模型仓库的引用,将旧的“damo”命名空间替换为通义实验室的“iic”命名空间。这一更改应用于文档和核心运行脚本,旨在避免重定向问题并确保模型路径的正确性。此外,文档中的一个次要拼写错误也得到了修正。

Highlights

  • 模型路径更新: 将文档和运行脚本中所有模型路径的前缀从 "damo/" 更新为 "iic/",以反映魔搭社区的命名空间变更。
  • 文档拼写修正: 修复了文档中一处拼写错误,将 "lagre" 更正为 "large"。
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

您好,感谢您的贡献!本次PR更新了模型路径并修复了拼写错误,方向是正确的。不过,为了确保项目的一致性,建议将相关的修改应用到所有文件中。我发现英文文档 runtime/docs/SDK_advanced_guide_offline_gpu.md 和性能测试文档 runtime/docs/benchmark_onnx_cpp.md 中仍在使用旧的 damo 路径,并且英文文档中也存在 lagre 的拼写错误。建议在本次提交中一并修复这些问题,以保持代码库的同步和整洁。我在代码中留下了具体的评论以供参考。

[Paraformer-lagre模型](https://www.modelscope.cn/models/damo/speech_paraformer-large_asr_nat-zh-cn-16k-common-vocab8404-pytorch/summary),
[CT-Transformer标点预测模型](https://www.modelscope.cn/models/damo/punc_ct-transformer_cn-en-common-vocab471067-large-onnx/summary),
[FSMN-VAD模型](https://www.modelscope.cn/models/iic/speech_fsmn_vad_zh-cn-16k-common-onnx/summary),
[Paraformer-large模型](https://www.modelscope.cn/models/iic/speech_paraformer-large_asr_nat-zh-cn-16k-common-vocab8404-pytorch/summary),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

拼写错误 lagre -> large 已修正,很好。不过,对应的英文文档 runtime/docs/SDK_advanced_guide_offline_gpu.md 中似乎还存在同样的拼写错误,建议一并修正以保持文档同步。

Comment on lines +3 to +7
model_dir="iic/speech_paraformer-large-vad-punc_asr_nat-zh-cn-16k-common-vocab8404-onnx"
vad_dir="iic/speech_fsmn_vad_zh-cn-16k-common-onnx"
punc_dir="iic/punc_ct-transformer_cn-en-common-vocab471067-large-onnx"
itn_dir="thuduj12/fst_itn_zh"
lm_dir="damo/speech_ngram_lm_zh-cn-ai-wesp-fst"
lm_dir="iic/speech_ngram_lm_zh-cn-ai-wesp-fst"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

模型路径从 damo 更新为 iic 是正确的。但为了保持整个项目的一致性,建议检查并更新其他文件中所有相关的 damo 路径。例如,runtime/docs/SDK_advanced_guide_offline_gpu.mdruntime/docs/benchmark_onnx_cpp.md 文件中似乎仍在使用旧的路径。

@LauraGPT LauraGPT merged commit fa9a6cd into modelscope:main Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants