Skip to content

Fix ios 9 crash #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix ios 9 crash #25

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f503fa5
fix iOS 9 crash (https://github.com/mokagio/UICollectionViewLeftAlign…
petropavel13 Dec 7, 2017
caf0898
apply fix only for iOS < 10.0
petropavel13 Dec 11, 2017
ee7faec
use @available check
petropavel13 Jul 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion UICollectionViewLeftAlignedLayout/UICollectionViewLeftAlignedLayout.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,14 @@ - (NSArray *)layoutAttributesForElementsInRect:(CGRect)rect {
}

- (UICollectionViewLayoutAttributes *)layoutAttributesForItemAtIndexPath:(NSIndexPath *)indexPath {
UICollectionViewLayoutAttributes* currentItemAttributes = [[super layoutAttributesForItemAtIndexPath:indexPath] copy];
UICollectionViewLayoutAttributes* currentItemAttributes;

if (UIDevice.currentDevice.systemVersion.floatValue < 10.0) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would prefer if (@available(iOS 10, *)) { be used here.

However, are there any detrimental effects of using copy all the time? @petropavel13

Copy link
Author

@petropavel13 petropavel13 Jul 7, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!
Added available check.
There is no issues detected since december.

currentItemAttributes = [super layoutAttributesForItemAtIndexPath:indexPath];
} else {
currentItemAttributes = [[super layoutAttributesForItemAtIndexPath:indexPath] copy];
}

UIEdgeInsets sectionInset = [self evaluatedSectionInsetForItemAtIndex:indexPath.section];

BOOL isFirstItemInSection = indexPath.item == 0;
Expand Down