Use docs-builder-bot credentials for all git clone operations (#802)

schmalliso · web-flow · commit 8c53dc6952ce · 2023-04-18T15:25:05.000-04:00
* support private repos that aren't in 10gen

* clarify why
diff --git a/src/services/repo.ts b/src/services/repo.ts
@@ -32,10 +32,11 @@ export class GitHubConnector implements IRepoConnector {
     this._fileSystemService = fileSystemService;
   }
 
+  // make everything use credentials to support "internal" repos
   private getBasePath(job: Job): string {
     const botName = this._config.get<string>('githubBotUserName');
     const botPw = this._config.get<string>('githubBotPW');
-    return job.payload.private ? `https://${botName}:${botPw}@github.com` : 'https://github.com';
+    return `https://${botName}:${botPw}@github.com`;
   }
 
   async applyPatch(job: Job): Promise<any> {

Original file line number	Diff line number	Diff line change
`@@ -32,10 +32,11 @@ export class GitHubConnector implements IRepoConnector {`
`32`	`32`	`this._fileSystemService = fileSystemService;`
`33`	`33`	`}`
`34`	`34`
	`35`	`+ // make everything use credentials to support "internal" repos`
`35`	`36`	`private getBasePath(job: Job): string {`
`36`	`37`	`const botName = this._config.get<string>('githubBotUserName');`
`37`	`38`	`const botPw = this._config.get<string>('githubBotPW');`
`38`		- return job.payload.private ? `https://${botName}:${botPw}@github.com` : 'https://github.com';
	`39`	+ return `https://${botName}:${botPw}@github.com`;
`39`	`40`	`}`
`40`	`41`
`41`	`42`	`async applyPatch(job: Job): Promise<any> {`