Merge pull request #94 from mongodb/fixes-cloud-provider-snapshot-backup-policy-data-type-issue

fix: fixes #93 CloudProviderSnapshotBackupPolicy zero values are ignored

Author: gmlp

mongodbatlas/cloud_provider_snapshot_backup_policies.go

@@ -30,10 +30,10 @@ var _ CloudProviderSnapshotBackupPoliciesService = &CloudProviderSnapshotBackupP
 type CloudProviderSnapshotBackupPolicy struct {
 	ClusterID             string   `json:"clusterId,omitempty"`             //	Unique identifier of the Atlas cluster.
 	ClusterName           string   `json:"clusterName,omitempty"`           //	Name of the Atlas cluster.
-	ReferenceHourOfDay    int      `json:"referenceHourOfDay,omitempty"`    // UTC Hour of day between 0 and 23, inclusive, representing which hour of the day that Atlas takes snapshots for backup policy items.
-	ReferenceMinuteOfHour int      `json:"referenceMinuteOfHour,omitempty"` // UTC Minutes after referenceHourOfDay that Atlas takes snapshots for backup policy items. Must be between 0 and 59, inclusive. Number of days back in time you can restore to with point-in-time accuracy.
-	RestoreWindowDays     int      `json:"restoreWindowDays,omitempty"`     // Number of days back in time you can restore to with point-in-time accuracy. Must be a positive, non-zero integer.
-	UpdateSnapshots       bool     `json:"updateSnapshots,omitempty"`       // Specify true to apply the retention changes in the updated backup policy to snapshots that Atlas took previously.
+	ReferenceHourOfDay    *int64   `json:"referenceHourOfDay,omitempty"`    // UTC Hour of day between 0 and 23, inclusive, representing which hour of the day that Atlas takes snapshots for backup policy items.
+	ReferenceMinuteOfHour *int64   `json:"referenceMinuteOfHour,omitempty"` // UTC Minutes after referenceHourOfDay that Atlas takes snapshots for backup policy items. Must be between 0 and 59, inclusive. Number of days back in time you can restore to with point-in-time accuracy.
+	RestoreWindowDays     *int64   `json:"restoreWindowDays,omitempty"`     // Number of days back in time you can restore to with point-in-time accuracy. Must be a positive, non-zero integer.
+	UpdateSnapshots       *bool    `json:"updateSnapshots,omitempty"`       // Specify true to apply the retention changes in the updated backup policy to snapshots that Atlas took previously.
 	NextSnapshot          string   `json:"nextSnapshot,omitempty"`          // UTC ISO 8601 formatted point in time when Atlas will take the next snapshot.
 	Policies              []Policy `json:"policies,omitempty"`              // A list of policy definitions for the cluster.
 }

mongodbatlas/cloud_provider_snapshot_backup_policies_test.go

@@ -7,6 +7,7 @@ import (
 	"testing"
 
 	"github.com/go-test/deep"
+	"github.com/openlyinc/pointy"
 )
 
 func TestCloudProviderSnapshotBackupPolicies_Get(t *testing.T) {
@@ -119,9 +120,9 @@ func TestCloudProviderSnapshotBackupPolicies_Get(t *testing.T) {
 				},
 			},
 		},
-		ReferenceHourOfDay:    17,
-		ReferenceMinuteOfHour: 24,
-		RestoreWindowDays:     7,
+		ReferenceHourOfDay:    pointy.Int64(17),
+		ReferenceMinuteOfHour: pointy.Int64(24),
+		RestoreWindowDays:     pointy.Int64(7),
 	}
 
 	if diff := deep.Equal(snapshotBackupPolicy, expected); diff != nil {
@@ -217,8 +218,8 @@ func TestCloudProviderSnapshotBackupPolicies_Update(t *testing.T) {
 	})
 
 	updateRequest := &CloudProviderSnapshotBackupPolicy{
-		ReferenceHourOfDay:    12,
-		ReferenceMinuteOfHour: 30,
+		ReferenceHourOfDay:    pointy.Int64(12),
+		ReferenceMinuteOfHour: pointy.Int64(30),
 		Policies: []Policy{
 			{
 				ID: "5c95242c87d9d636e70c28ef",
@@ -240,7 +241,7 @@ func TestCloudProviderSnapshotBackupPolicies_Update(t *testing.T) {
 				},
 			},
 		},
-		UpdateSnapshots: true,
+		UpdateSnapshots: pointy.Bool(true),
 	}
 
 	cloudProviderSnapshot, _, err := client.CloudProviderSnapshotBackupPolicies.Update(ctx, groupID, clusterName, updateRequest)
@@ -273,8 +274,8 @@ func TestCloudProviderSnapshotBackupPolicies_Update(t *testing.T) {
 				},
 			},
 		},
-		ReferenceHourOfDay:    12,
-		ReferenceMinuteOfHour: 30,
+		ReferenceHourOfDay:    pointy.Int64(12),
+		ReferenceMinuteOfHour: pointy.Int64(30),
 	}
 
 	if diff := deep.Equal(cloudProviderSnapshot, expected); diff != nil {