Skip to content

Commit c0d08cf

Browse files
committed
address more pr comments
1 parent 121021d commit c0d08cf

File tree

3 files changed

+4
-17
lines changed

3 files changed

+4
-17
lines changed

src/MongoDB.Driver/IndexKeysDefinitionBuilder.cs

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -487,20 +487,7 @@ public override BsonDocument Render(RenderArgs<TDocument> args)
487487
{
488488
var renderedField = _field.Render(args);
489489

490-
BsonValue value;
491-
switch (_direction)
492-
{
493-
case SortDirection.Ascending:
494-
value = 1;
495-
break;
496-
case SortDirection.Descending:
497-
value = -1;
498-
break;
499-
default:
500-
throw new InvalidOperationException("Unknown value for " + typeof(SortDirection) + ".");
501-
}
502-
503-
return new BsonDocument(renderedField.FieldName, value);
490+
return new BsonDocument(renderedField.FieldName, _direction.Render());
504491
}
505492
}
506493

src/MongoDB.Driver/SortDefinitionBuilder.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -295,7 +295,7 @@ public override BsonDocument Render(RenderArgs<TDocument> args)
295295
{
296296
var renderedField = _field.Render(args);
297297

298-
return new BsonDocument(renderedField.FieldName, _direction.ToBsonValue());
298+
return new BsonDocument(renderedField.FieldName, _direction.Render());
299299
}
300300
}
301301

@@ -308,7 +308,7 @@ public ValueDirectionalSortDefinition(SortDirection direction)
308308
_direction = direction;
309309
}
310310

311-
internal override BsonValue RenderAsBsonValue(RenderArgs<TDocument> args) => _direction.ToBsonValue();
311+
internal override BsonValue RenderAsBsonValue(RenderArgs<TDocument> args) => _direction.Render();
312312

313313
public override BsonDocument Render(RenderArgs<TDocument> args)
314314
{

src/MongoDB.Driver/SortDirectionExtensions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ namespace MongoDB.Driver
2020
{
2121
internal static class SortDirectionExtensions
2222
{
23-
internal static BsonValue ToBsonValue(this SortDirection direction)
23+
internal static BsonValue Render(this SortDirection direction)
2424
{
2525
return direction switch
2626
{

0 commit comments

Comments
 (0)