Skip to content

Commit f670f33

Browse files
committed
add context to function signatures
1 parent 4707e11 commit f670f33

File tree

1 file changed

+7
-10
lines changed

1 file changed

+7
-10
lines changed

internal/cmd/perfcomp/main.go

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ func main() {
162162
log.Fatalf("Error getting raw data: %v", err)
163163
}
164164

165-
allEnergyStats, err := getEnergyStatsForAllBenchMarks(patchRawData, db.Collection(stableRegionsColl))
165+
allEnergyStats, err := getEnergyStatsForAllBenchMarks(findCtx, patchRawData, db.Collection(stableRegionsColl))
166166
if err != nil {
167167
log.Fatalf("Error getting energy statistics: %v", err)
168168
}
@@ -208,7 +208,7 @@ func findRawData(ctx context.Context, project string, version string, coll *mong
208208
}
209209

210210
// Find the most recent stable region of the mainline version for a specific test/measurement
211-
func findLastStableRegion(project string, testname string, measurement string, coll *mongo.Collection) (*StableRegion, error) {
211+
func findLastStableRegion(ctx context.Context, project string, testname string, measurement string, coll *mongo.Collection) (*StableRegion, error) {
212212
filter := bson.D{
213213
{"time_series_info.project", project},
214214
{"time_series_info.variant", "perf"},
@@ -221,19 +221,16 @@ func findLastStableRegion(project string, testname string, measurement string, c
221221

222222
findOptions := options.FindOne().SetSort(bson.D{{"end", -1}})
223223

224-
findCtx, cancel := context.WithTimeout(context.Background(), 180*time.Second)
225-
defer cancel()
226-
227224
var sr *StableRegion
228-
err := coll.FindOne(findCtx, filter, findOptions).Decode(&sr)
225+
err := coll.FindOne(ctx, filter, findOptions).Decode(&sr)
229226
if err != nil {
230227
return nil, err
231228
}
232229
return sr, nil
233230
}
234231

235232
// For a specific test and measurement
236-
func getEnergyStatsForOneBenchmark(rd RawData, coll *mongo.Collection) ([]*EnergyStats, error) {
233+
func getEnergyStatsForOneBenchmark(ctx context.Context, rd RawData, coll *mongo.Collection) ([]*EnergyStats, error) {
237234
testname := rd.Info.TestName
238235
var energyStats []*EnergyStats
239236

@@ -242,7 +239,7 @@ func getEnergyStatsForOneBenchmark(rd RawData, coll *mongo.Collection) ([]*Energ
242239
measName := rd.Rollups.Stats[i].Name
243240
measVal := rd.Rollups.Stats[i].Val
244241

245-
stableRegion, err := findLastStableRegion(project, testname, measName, coll)
242+
stableRegion, err := findLastStableRegion(ctx, project, testname, measName, coll)
246243
if err != nil {
247244
log.Fatalf(
248245
"Error finding last stable region for test %q, measurement %q: %v",
@@ -288,10 +285,10 @@ func getEnergyStatsForOneBenchmark(rd RawData, coll *mongo.Collection) ([]*Energ
288285
return energyStats, nil
289286
}
290287

291-
func getEnergyStatsForAllBenchMarks(patchRawData []RawData, coll *mongo.Collection) ([]*EnergyStats, error) {
288+
func getEnergyStatsForAllBenchMarks(ctx context.Context, patchRawData []RawData, coll *mongo.Collection) ([]*EnergyStats, error) {
292289
var allEnergyStats []*EnergyStats
293290
for _, rd := range patchRawData {
294-
energyStats, err := getEnergyStatsForOneBenchmark(rd, coll)
291+
energyStats, err := getEnergyStatsForOneBenchmark(ctx, rd, coll)
295292
if err != nil {
296293
return nil, err
297294
}

0 commit comments

Comments
 (0)