validates_numericality_of works differently in 8.1.1 because of type cast

[artur79]

I'm upgrading Rails app from mongoid 7.5 to 8.1.1. I had validations like:

field :number_per_year, type: Float, default: 0

validates_numericality_of :number_per_year, allow_blank: true

When using 7.5 and I pass e.g. string 'foo' validation does not pass as expected. But in mongoid 8.1.1 as I'v found when passing string and it's not a number it's casted to number, if cast can not be done it's silently converted to nil. So now my validation passes when it should not. I'v refactored it that way:

validates_numericality_of :number_per_year, if: -> { number_per_year_before_type_cast.present? }

It works as expected now but I want to make sure are there any drawbacks/dangers in that approach?

[johnnyshields]

My recommendation as a long time Mongoid user is to stay on Mongoid 7.x.

[artur79]

Of course you can do that as well!

plus I guess you slack dependecies to make it work with rails 8 because mongo 7.5 requires activemodel to be < 7.1 https://github.com/mongodb/mongoid/blob/7.5-stable/mongoid.gemspec#L40C3-L40C65

It's still a bit confusing for me, do you use on prod rails 8 app with official mongoid plus that patch applied (plus lose dependencies, otherwise bundler won't allow you to install both) or do you use mongoid-ultra there

[artur79]

Of course you can do that as well!

or if I include it in Gemfile like this

gem 'mongoid', '7.5.4', git: 'https://github.com/tablecheck/mongoid-ultra.git', branch: '7.5-stable'

is this the mongoid version 7.5 with minimal changes to make it work with rails 8 ?

[johnnyshields]

I use this commit ref on prod with Rails 8:
tablecheck/mongoid-ultra@4c4593e

[artur79]

I use this commit ref on prod with Rails 8: tablecheck/mongoid-ultra@4c4593e

ok, I think I got it now, like ?

gem 'mongoid',
    github: 'tablecheck/mongoid-ultra',
    branch: '7.5-stable',
    ref: '4c4593e'

[johnnyshields]

Yes, that looks correct.