Skip to content

Create defensive copy of grpc.Metadata #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jasper-M wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Create defensive copy of grpc.Metadata #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion grpc-runtime/src/main/scala/monix/grpc/runtime/client/ClientCall.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,10 +194,19 @@ class ClientCall[Request, Response] private[client] (
case Right(_) => Task.raiseError(err)
}

private def copy(origHeaders: grpc.Metadata): grpc.Metadata = {
val newHeaders = new grpc.Metadata()
newHeaders.merge(origHeaders)
newHeaders
}

/**
* Creates a copy of the headers, because call.start can mutate them.
*/
private def start(
listener: grpc.ClientCall.Listener[Response],
headers: grpc.Metadata
): Task[Unit] = Task(call.start(listener, headers))
): Task[Unit] = Task(call.start(listener, copy(headers)))

/**
* Asks for two messages even though we expect only one so that if a
Expand Down