feat(bytes): implement ToJson for BytesView

Author: bobzhang

builtin/json.mbt

@@ -189,8 +189,7 @@ pub impl ToJson for Bytes with to_json(self : Bytes) -> Json {
       sb.write_char(b.to_char())
     } else {
       sb.write_string("\\x")
-      sb.write_char(to_hex_digit(b.to_int() / 16))
-      sb.write_char(to_hex_digit(b.to_int() % 16))
+      sb.write_string(b.to_int().to_string(radix=16))
     }
   }
   Json::string(sb.to_string())

builtin/show.mbt

@@ -61,38 +61,11 @@ pub impl Show for UInt16 with output(self, logger) {
   self.to_int().output(logger)
 }
 
-///|
-fn to_hex_digit(i : Int) -> Char {
-  if i < 10 {
-    (i + '0').unsafe_to_char()
-  } else {
-    (i + 'a' - 10).unsafe_to_char()
-  }
-}
-
-///|
-test "to_hex_digit" {
-  for i in 0..<10 {
-    guard to_hex_digit(i) == ('0'.to_int() + i).unsafe_to_char() else {
-      fail("to_hex_digit(\{i}) does not match")
-    }
-  }
-  for i in 10..<16 {
-    guard to_hex_digit(i) == ('a'.to_int() + (i - 10)).unsafe_to_char() else {
-      fail("to_hex_digit(\{i}) does not match")
-    }
-  }
-}
-
 ///|
 pub impl Show for Bytes with output(self, logger) {
   logger.write_string("b\"")
   for b in self {
-    let byte = b.to_int()
-    logger
-    ..write_string("\\x")
-    ..write_char(to_hex_digit(byte / 16))
-    ..write_char(to_hex_digit(byte % 16))
+    logger..write_string("\\x")..write_string(b.to_int().to_string(radix=16))
   }
   logger.write_string("\"")
 }
@@ -151,8 +124,7 @@ pub impl Show for String with output(self, logger) {
           flush_segment(seg, i)
           logger
           ..write_string("\\u{")
-          ..write_char(to_hex_digit(code / 16))
-          ..write_char(to_hex_digit(code % 16))
+          ..write_string(code.to_string(radix=16))
           ..write_char('}')
           continue i + 1, i + 1
         } else {

bytes/pkg.generated.mbti

@@ -71,6 +71,7 @@ impl Compare for BytesView
 impl Eq for BytesView
 impl Hash for BytesView
 impl Show for BytesView
+impl ToJson for BytesView
 
 // Type aliases
 pub typealias BytesView as View

bytes/view.mbt

@@ -653,3 +653,17 @@ pub impl Hash for BytesView with hash_combine(self : BytesView, hasher : Hasher)
 pub impl Hash for BytesView with hash(self : BytesView) -> Int {
   xxhash32(self.data(), 0, offset=self.start_offset(), len=self.length())
 }
+
+///|
+pub impl ToJson for BytesView with to_json(self) -> Json {
+  let sb = StringBuilder::new()
+  for b in self {
+    if b is (b' '..=b'~') && b != b'"' && b != b'\\' {
+      sb.write_char(b.to_char())
+    } else {
+      sb.write_string("\\x")
+      sb.write_string(b.to_int().to_string(radix=16))
+    }
+  }
+  Json::string(sb.to_string())
+}