Skip to content

Commit f4f13b1

Browse files
rwlbuismnutt
authored andcommitted
[popover] Adjust showPopover
https://bugs.webkit.org/show_bug.cgi?id=258800 Reviewed by Tim Nguyen. Adjust to spec change: whatwg/html#9439 There should be no behavior change that can be tested. * Source/WebCore/html/HTMLElement.cpp: (WebCore::HTMLElement::showPopover): Canonical link: https://commits.webkit.org/265734@main
1 parent 46c5871 commit f4f13b1

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

Source/WebCore/html/HTMLElement.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1349,15 +1349,15 @@ void HTMLElement::queuePopoverToggleEventTask(PopoverVisibilityState oldState, P
13491349

13501350
ExceptionOr<void> HTMLElement::showPopover(const HTMLFormControlElement* invoker)
13511351
{
1352-
if (popoverData())
1353-
popoverData()->setInvoker(invoker);
1354-
13551352
auto check = checkPopoverValidity(*this, PopoverVisibilityState::Hidden);
13561353
if (check.hasException())
13571354
return check.releaseException();
13581355
if (!check.returnValue())
13591356
return { };
13601357

1358+
if (popoverData())
1359+
popoverData()->setInvoker(invoker);
1360+
13611361
ASSERT(!isInTopLayer());
13621362

13631363
PopoverData::ScopedStartShowingOrHiding showOrHidingPopoverScope(*this);

0 commit comments

Comments
 (0)