Refactor URL generation in docs view and enhance test assertions

- Introduced a helper function `get_url` to streamline URL construction in the `docs` view.
- Updated test cases to assert the presence of the `utm_referrer=amo` query parameter for 301 redirects.
- Improved readability of the test case by unpacking the URL and status code directly in the loop.

Author: KevinMind

src/olympia/devhub/tests/test_views.py

@@ -2066,11 +2066,14 @@ def test_doc_urls(self):
 
         index = reverse('devhub.index')
 
-        for url in urls:
-            response = self.client.get(url[0])
-            assert response.status_code == url[1]
+        for [url, status_code] in urls:
+            response = self.client.get(url)
+            assert response.status_code == status_code
+
+            if status_code == 301:
+                assert 'utm_referrer=amo' in response.url
 
-            if url[1] == 302:  # Redirect to the index page
+            if status_code == 302:  # Redirect to the index page
                 self.assert3xx(response, index)
 
 

src/olympia/devhub/views.py

@@ -2,7 +2,7 @@
 import os
 import time
 from copy import deepcopy
-from urllib.parse import quote
+from urllib.parse import quote, urlencode, urljoin
 from uuid import UUID, uuid4
 
 from django import forms as django_forms, http
@@ -1951,11 +1951,16 @@ def request_review(request, addon_id, addon):
 
 
 def docs(request, doc_name=None):
+    def get_url(base, doc=None):
+        base_url = urljoin(base, doc)
+        query = urlencode({'utm_referrer': 'amo'})
+        return f'{base_url}?{query}'
+
     def mdn_url(doc):
-        return MDN_BASE + doc
+        return get_url(MDN_BASE, doc)
 
     def ext_url(doc):
-        return settings.EXTENSION_WORKSHOP_URL + doc
+        return get_url(settings.EXTENSION_WORKSHOP_URL, doc)
 
     mdn_docs = {
         None: mdn_url(''),