From 45d546cbc26a565d7f8fae58667c21ea421610dc Mon Sep 17 00:00:00 2001 From: Christian Franke Date: Mon, 12 Oct 2020 13:53:51 +0200 Subject: [PATCH] tests: Ensure authenticate returns newly created user When a new user is created, `authenticate` should return it. Without the change, the test would also pass if `authenticate` returned `None`, which is incorrect behavior. --- tests/test_auth.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/test_auth.py b/tests/test_auth.py index fde90d7d..e18b7925 100644 --- a/tests/test_auth.py +++ b/tests/test_auth.py @@ -447,9 +447,9 @@ def test_successful_authentication_new_user(self, token_mock, request_mock, algo 'redirect_uri': 'http://testserver/callback/', } self.assertEqual(User.objects.all().count(), 0) - self.backend.authenticate(request=auth_request) + user = self.backend.authenticate(request=auth_request) self.assertEqual(User.objects.all().count(), 1) - user = User.objects.all()[0] + self.assertEqual(user, User.objects.get()) self.assertEqual(user.email, 'email@example.com') self.assertEqual(user.username, 'username_algo')