Remove the shadow from the links (bug 1974436)

calixteman · calixteman · commit fc9ba0cda3e8 · 2025-06-30T21:39:22.000+02:00
The shadow was taken into account when computing the bounding box of the section
containing the link and it was making the clip path wrong.
Since the shadow is almost invisible because of the opacity, the yellow color and the clip
we can remove it without causing any visual regressions (and as a side effect it'll avoid
to use resources to compute it when displayed).
diff --git a/test/pdfs/.gitignore b/test/pdfs/.gitignore
@@ -728,3 +728,4 @@
 !issue19517.pdf
 !empty#hash.pdf
 !bug1885505.pdf
+!bug1974436.pdf
diff --git a/test/pdfs/bug1974436.pdf b/test/pdfs/bug1974436.pdf
diff --git a/test/test_manifest.json b/test/test_manifest.json
@@ -12140,5 +12140,13 @@
     "type": "eq",
     "forms": true,
     "link": true
+  },
+  {
+    "id": "bug1974436",
+    "file": "pdfs/bug1974436.pdf",
+    "md5": "538b64d6781ac370e29887c9805063af",
+    "rounds": 1,
+    "type": "eq",
+    "annotations": true
   }
 ]
diff --git a/web/annotation_layer_builder.css b/web/annotation_layer_builder.css
@@ -155,7 +155,6 @@
     > a:hover {
     opacity: 0.2;
     background-color: rgb(255 255 0);
-    box-shadow: 0 2px 10px rgb(255 255 0);
   }
 
   .linkAnnotation.hasBorder:hover {

Original file line number	Diff line number	Diff line change
`@@ -12140,5 +12140,13 @@`
`12140`	`12140`	`"type": "eq",`
`12141`	`12141`	`"forms": true,`
`12142`	`12142`	`"link": true`
	`12143`	`+ },`
	`12144`	`+ {`
	`12145`	`+ "id": "bug1974436",`
	`12146`	`+ "file": "pdfs/bug1974436.pdf",`
	`12147`	`+ "md5": "538b64d6781ac370e29887c9805063af",`
	`12148`	`+ "rounds": 1,`
	`12149`	`+ "type": "eq",`
	`12150`	`+ "annotations": true`
`12143`	`12151`	`}`
`12144`	`12152`	`]`
Original file line number	Diff line number	Diff line change
`@@ -155,7 +155,6 @@`
`155`	`155`	`> a:hover {`
`156`	`156`	`opacity: 0.2;`
`157`	`157`	`background-color: rgb(255 255 0);`
`158`		`- box-shadow: 0 2px 10px rgb(255 255 0);`
`159`	`158`	`}`
`160`	`159`
`161`	`160`	`.linkAnnotation.hasBorder:hover {`