sub: remove upper limits of margin-x and margin-y #16772
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have this problem where I'd like to set
sub-margin-xto values greater than 300 (the current hard limit). This happens in two cases:sub-margin-xvalues required to get the subtitles to a comfortable width get very large. A value of 800-900 worked best for me here.This PR increases the hard limit from 300 to 1200 since 1200 is about the largest I ever needed plus some headroom.
It might make sense to further increase this value or maybe introduce something like
sub-max-sizesince people with some insanely wide monitors might need even larger values.Also sorry if there's already some option that covers this...