Fixes #4241 #4250
Closed
Fixes #4241 #4250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is not a proper fix, just a workaround. It doesn't fix the crash, it only blocks the ability to use the weapon ID |
|
@ColombuxMaximus Thanks for the PR. |
I'll try later, let's close this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4241 (Using a weapon model id for engineRequestModel and then replacing it crashes the game)
Before you go ahead and create a pull request, please make sure:
If your work is incomplete, do not prefix your pull request with "WIP", instead
create a draft pull request: https://github.blog/2019-02-14-introducing-draft-pull-requests/
Thank you!