Remove create_is_missing

instead handle the error in remote.

Author: rklaehn

src/api/blobs.rs

@@ -302,7 +302,6 @@ impl Blobs {
             ExportBaoRequest {
                 hash: hash.into(),
                 ranges: ranges.into(),
-                create_if_missing: false,
             },
             32,
         )

src/api/proto.rs

@@ -222,7 +222,6 @@ pub struct ObserveRequest {
 pub struct ExportBaoRequest {
     pub hash: Hash,
     pub ranges: ChunkRanges,
-    pub create_if_missing: bool,
 }
 
 /// Export the given ranges as chunkks, without validation.

src/api/remote.rs

@@ -420,14 +420,14 @@ impl Remote {
             let opts = ExportBaoOptions {
                 hash: root,
                 ranges: bitfield.ranges.clone(),
-                create_if_missing: true,
             };
             let bao = self.store().export_bao_with_opts(opts, 32);
             let mut by_index = BTreeMap::new();
             let mut stream = bao.hashes_with_index();
             while let Some(item) = stream.next().await {
-                let (index, hash) = item?;
-                by_index.insert(index, hash);
+                if let Ok((index, hash)) = item {
+                    by_index.insert(index, hash);
+                }
             }
             let mut bitfields = BTreeMap::new();
             let mut hash_seq = BTreeMap::new();

src/store/fs.rs

@@ -1028,7 +1028,7 @@ async fn export_ranges_impl(
 
 #[instrument(skip_all, fields(hash = %cmd.hash_short()))]
 async fn export_bao(mut cmd: ExportBaoMsg, ctx: HashContext) {
-    match ctx.get_maybe_create(cmd.hash, cmd.create_if_missing).await {
+    match ctx.get_maybe_create(cmd.hash, false).await {
         Ok(handle) => {
             if let Err(cause) = export_bao_impl(cmd.inner, &mut cmd.tx, handle).await {
                 cmd.tx

src/store/mem.rs

@@ -190,20 +190,11 @@ impl Actor {
                 self.spawn(import_path(cmd));
             }
             Command::ExportBao(ExportBaoMsg {
-                inner:
-                    ExportBaoRequest {
-                        hash,
-                        ranges,
-                        create_if_missing,
-                    },
+                inner: ExportBaoRequest { hash, ranges },
                 tx,
                 ..
             }) => {
-                let entry = if create_if_missing {
-                    Some(self.get_or_create_entry(hash))
-                } else {
-                    self.get(&hash)
-                };
+                let entry = self.get(&hash);
                 self.spawn(export_bao(entry, ranges, tx))
             }
             Command::ExportPath(cmd) => {