Skip to content

[BUG] Configured lossy_bitrate not used #823

@cs-t1

Description

@cs-t1

Describe the bug

I'm having the issue of ffmpeg not been given the correct bitrate flag for song conversion. Upon reading through the code, it seems to me that the lossy_bitrate field in the config file is never used, thus the conversion engine using its default value (-q:a 0)

Thanks :)

Command Used

rip --quality 1 --folder . url <url>

Debug Traceback

Not applicable

Config File

# Convert tracks to a codec after downloading them.
[conversion]
enabled = true
# FLAC, ALAC, OPUS, MP3, VORBIS, or AAC
codec = "MP3"
# In Hz. Tracks are downsampled if their sampling rate is greater than this. 
# Value of 48000 is recommended to maximize quality and minimize space
sampling_rate = 48000
# Only 16 and 24 are available. It is only applied when the bit depth is higher
# than this value.
bit_depth = 24
# Only applicable for lossy codecs
lossy_bitrate = 320

Operating System

Linux

streamrip version

2.0.5

Screenshots and recordings

No response

Additional context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions