Refactor process append entry #7224
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sciascid
force-pushed
the
refactor-process-append-entry
branch
from
720f1d8 to
e83a660
Compare
sciascid
force-pushed
the
refactor-process-append-entry
branch
from
e83a660 to
9c2a14f
Compare
sciascid
force-pushed
the
refactor-process-append-entry
branch
from
9c2a14f to
eedb125
Compare
Done |
Extract recoverAppendEntry() from processAppendEntry(), separating the normal path from recovery path. This allows to simplify processAppendEntry() by removing checks for for `sub == nil`, as subscription is always given Extract processAppendEntryLocked() from processAppendEntry(). processAppendEntryLocked() does the actual processing of the appendEntry under lock protection, and optionally returns a pointer to a appendEntryResponse. processAppendEntry() is responsible for sending the response and returning it to its pool (if any). Signed-off-by: Daniele Sciascia <[email protected]>
sciascid
force-pushed
the
refactor-process-append-entry
branch
from
eedb125 to
acb54f1
Compare
neilalexander
added
the
post-freeze
sciascid
force-pushed
the
refactor-process-append-entry
branch
from
705d478 to
98bac1f
Compare
Remove sub parameter from processAppendEntry, appendEntry already stores sub. Move all subscription pointer comparisons from processAppendEntryLocked to processAppendEntry. processAppendEntryLocked takes now a boolean instead of a subscription pointer. Signed-off-by: Daniele Sciascia <[email protected]>
sciascid
force-pushed
the
refactor-process-append-entry
branch
from
98bac1f to
134258f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor processAppendEntry. Separate commits to simplify review, may be squashed later on.
Signed-off-by: Daniele [email protected]