-
Notifications
You must be signed in to change notification settings - Fork 173
Modernize README #356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize README #356
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea to go over the readme. I like the changes, I think they are a large improvement.
| ### [<img width="25" height="25" src="doc/images/logos/nature_robots_icon.jpg"> Nature Robots](https://naturerobots.com/) | ||
| The latest version (ROS2) is developed and maintained by Nature Robots. | ||
|
|
||
| ## Further Resources |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
most of the resources are ROS1 only. Except:
I think the resources that only work with ROS1 could be dropped from this list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, I will remove them with the next commit 👍
| ## Announcements & News | ||
| ### 16.10.2024 First ROS2 Version of Move Base Flex | ||
| The first working ROS2 version of Move Base Flex has been published. | ||
| It targets the ROS2 distro `humble` and includes most components you know from ROS1: | ||
| - mbf_abstract_core & mbf_abstract_nav | ||
| - mbf_simple_core & mbf_simple_nav (for navigation components that need no map representation) | ||
| - mbf_utility | ||
| - mbf_msgs | ||
| * **Modular Action-Based Architecture** | ||
|
|
||
| Separate action servers for *path planning*, *control*, and *recovery* enable external [deliberation software](https://github.com/ros-wg-delib/awesome-ros-deliberation) (e.g., Behavior Trees, SMACH, or custom logic) to coordinate complex navigation strategies. | ||
|
|
||
| The ROS2 version comes with an additional package that helps with integration tests: | ||
| - mbf_test_utility (only a test dependency) | ||
| * **Extensible Plugin Framework** | ||
|
|
||
| Multiple planners, controllers, and recovery behaviors can be loaded simultaneously, selected at runtime, or executed in parallel using different concurrency slots. | ||
|
|
||
| These two packages not migrated: | ||
| - mbf_costmap_core & mbf_costmap_nav (for navigation components that utilize a 2D costmap). Nav2, which hosts the 2D costmap equivalent to the one from ROS1, and ROS1's move_base are quite different, so interfaces do not easily fit anymore. This makes migration hard. PRs are welcome for this. However, we might integrate another 2D grid map planning module soon. | ||
| * **Rich Feedback and Diagnostics** | ||
|
|
||
| All actions expose detailed feedback, results, and error codes, providing transparent runtime information for better debugging and system supervision. | ||
|
|
||
| Note that [mesh_navigation](https://github.com/naturerobots/mesh_navigation) is also available for ROS2, now. It provides navigation components that utilize 3D mesh maps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think keeping a high level overview over what has changed is useful.
I agree that this does not need to part of the readme, where the focus should be the current state, not the history.
I also we could lose some of the text I wrote regarding "16.10.2024 First ROS2 Version of Move Base Flex" :)
Can we move the info to another file or at the end of the readme?
Or do you think that this kind of info should not be present at all here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also thought about keeping the news somewhere. It would be fine to move it to the end of the file. Or maybe put it to the docs? https://naturerobots.github.io/mbf_docs/ . But those are still ROS 1, I think (?).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with the latest commit I readded the news to the end of the readme
Cakem1x
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for iterating, looks good to me!
I believe some parts of the README for the ROS 2 version of MBF feel a bit outdated. For instance, many newer ROS users are likely unfamiliar with the original move_base. I've therefore revised the README to better highlight MBF's current purpose and core features, focusing on its role and key design aspects rather than its historical context.
What do you think? I'm open to any feedback or ideas for improvement.