Skip to content

Commit 62d075a

Browse files
committed
Add neo4j-4.4.8-drop01.0 compat layer
1 parent c8282f9 commit 62d075a

File tree

8 files changed

+22
-0
lines changed

8 files changed

+22
-0
lines changed

cypher/cypher-test/src/test/java/org/neo4j/gds/storageengine/InMemoryNodeCursorTest.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ protected GraphStore graphStore() {
6464

6565
@Test
6666
@DisableForNeo4jVersion(Neo4jVersion.V_4_4_drop10)
67+
@DisableForNeo4jVersion(Neo4jVersion.V_4_4_8_drop10)
6768
@DisableForNeo4jVersion(Neo4jVersion.V_5_0_drop20)
6869
void shouldScanSingle() {
6970
nodeCursor.single(0);
@@ -73,6 +74,7 @@ void shouldScanSingle() {
7374

7475
@Test
7576
@DisableForNeo4jVersion(Neo4jVersion.V_4_4_drop10)
77+
@DisableForNeo4jVersion(Neo4jVersion.V_4_4_8_drop10)
7678
@DisableForNeo4jVersion(Neo4jVersion.V_5_0_drop20)
7779
void shouldScanRange() {
7880
nodeCursor.scanRange(1, 2);
@@ -85,6 +87,7 @@ void shouldScanRange() {
8587

8688
@Test
8789
@DisableForNeo4jVersion(Neo4jVersion.V_4_4_drop10)
90+
@DisableForNeo4jVersion(Neo4jVersion.V_4_4_8_drop10)
8891
@DisableForNeo4jVersion(Neo4jVersion.V_5_0_drop20)
8992
void shouldScanAll() {
9093
nodeCursor.scan();
@@ -98,6 +101,7 @@ void shouldScanAll() {
98101

99102
@Test
100103
@DisableForNeo4jVersion(Neo4jVersion.V_4_4_drop10)
104+
@DisableForNeo4jVersion(Neo4jVersion.V_4_4_8_drop10)
101105
@DisableForNeo4jVersion(Neo4jVersion.V_5_0_drop20)
102106
void testLabels() {
103107
graphStore.nodes().forEachNode(nodeId -> {
@@ -122,6 +126,7 @@ void shouldHaveProperties43() {
122126
@Test
123127
@DisableForNeo4jVersion(Neo4jVersion.V_4_3)
124128
@DisableForNeo4jVersion(Neo4jVersion.V_4_4_drop10)
129+
@DisableForNeo4jVersion(Neo4jVersion.V_4_4_8_drop10)
125130
@DisableForNeo4jVersion(Neo4jVersion.V_5_0_drop20)
126131
void shouldHaveProperties() {
127132
nodeCursor.next();
@@ -131,6 +136,7 @@ void shouldHaveProperties() {
131136

132137
@Test
133138
@DisableForNeo4jVersion(Neo4jVersion.V_4_4_drop10)
139+
@DisableForNeo4jVersion(Neo4jVersion.V_4_4_8_drop10)
134140
@DisableForNeo4jVersion(Neo4jVersion.V_5_0_drop20)
135141
void shouldTraverseProperties() throws TokenNotFoundException {
136142
nodeCursor.next();

cypher/cypher-test/src/test/java/org/neo4j/gds/storageengine/InMemoryRelationshipScanCursorTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@
4141
import static org.assertj.core.api.Assertions.assertThat;
4242

4343
@DisableForNeo4jVersion(Neo4jVersion.V_4_4_drop10)
44+
@DisableForNeo4jVersion(Neo4jVersion.V_4_4_8_drop10)
4445
@DisableForNeo4jVersion(Neo4jVersion.V_5_0_drop20)
4546
public class InMemoryRelationshipScanCursorTest extends CypherTest {
4647

cypher/cypher-test/src/test/java/org/neo4j/gds/storageengine/InMemoryRelationshipTraversalCursorTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@
4444
import static org.assertj.core.api.Assertions.assertThat;
4545

4646
@DisableForNeo4jVersion(Neo4jVersion.V_4_4_drop10)
47+
@DisableForNeo4jVersion(Neo4jVersion.V_4_4_8_drop10)
4748
@DisableForNeo4jVersion(Neo4jVersion.V_5_0_drop20)
4849
class InMemoryRelationshipTraversalCursorTest extends CypherTest {
4950

cypher/cypher-test/src/test/java/org/neo4j/internal/recordstorage/InMemoryStorageEngineTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
import static org.assertj.core.api.Assertions.assertThat;
3737

3838
@DisableForNeo4jVersion(Neo4jVersion.V_4_4_drop10)
39+
@DisableForNeo4jVersion(Neo4jVersion.V_4_4_8_drop10)
3940
@DisableForNeo4jVersion(Neo4jVersion.V_5_0_drop20)
4041
class InMemoryStorageEngineTest extends CypherTest {
4142

cypher/unsupported/storage-engine-adapter/src/main/java/org/neo4j/gds/compat/unsupported/StorageEngineProxyFactoryImpl.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ public class StorageEngineProxyFactoryImpl implements StorageEngineProxyFactory
3232

3333
private static final Collection<Neo4jVersion> incompatibleVersions = EnumSet.of(
3434
Neo4jVersion.V_4_4_drop10,
35+
Neo4jVersion.V_4_4_8_drop10,
3536
Neo4jVersion.V_5_0_drop20
3637
);
3738

neo4j-adapter/src/main/java/org/neo4j/gds/compat/Neo4jVersion.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ public enum Neo4jVersion {
2929
V_4_3,
3030
V_4_4,
3131
V_4_4_drop10,
32+
V_4_4_8_drop10,
3233
V_5_0_drop20,
3334
V_Dev;
3435

@@ -41,6 +42,8 @@ public String toString() {
4142
return "4.4";
4243
case V_4_4_drop10:
4344
return "4.4.7-drop01.0";
45+
case V_4_4_8_drop10:
46+
return "4.4.8-drop01.0";
4447
case V_5_0_drop20:
4548
return "5.0.0-drop02.0";
4649
case V_Dev:
@@ -82,6 +85,11 @@ static Neo4jVersion parse(String version) {
8285
if ("4.4.7-drop01.0".equals(version) || "4.4.6-drop01.0".equals(version)) {
8386
return Neo4jVersion.V_4_4_drop10;
8487
}
88+
89+
if ("4.4.8-drop01.0".equals(version)) {
90+
return Neo4jVersion.V_4_4_8_drop10;
91+
}
92+
8593
if ("5.0.0-drop02.0".equals(version)) {
8694
return Neo4jVersion.V_5_0_drop20;
8795
}

neo4j-adapter/src/test/java/org/neo4j/gds/compat/Neo4jVersionTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ class Neo4jVersionTest {
3939
"4.4.12, V_4_4",
4040
"4.4.6-drop01.0, V_4_4_drop10",
4141
"4.4.7-drop01.0, V_4_4_drop10",
42+
"4.4.8-drop01.0, V_4_4_8_drop10",
4243
"5.0.0-drop02.0, V_5_0_drop20",
4344
"5.0.0-dev, V_Dev",
4445
"dev, V_Dev",

proc/catalog/src/test/java/org/neo4j/gds/catalog/GraphStoreExportProcTest.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,7 @@ void teardown() {
9292

9393
@DisableForNeo4jVersion(Neo4jVersion.V_4_3)
9494
@DisableForNeo4jVersion(Neo4jVersion.V_4_4_drop10)
95+
@DisableForNeo4jVersion(Neo4jVersion.V_4_4_8_drop10)
9596
@Test
9697
void exportGraph() {
9798
projectGraph();
@@ -111,6 +112,7 @@ void exportGraph() {
111112

112113
@DisableForNeo4jVersion(Neo4jVersion.V_4_3)
113114
@DisableForNeo4jVersion(Neo4jVersion.V_4_4_drop10)
115+
@DisableForNeo4jVersion(Neo4jVersion.V_4_4_8_drop10)
114116
@Test
115117
void exportGraphWithAdditionalNodeProperties() {
116118
projectGraph();
@@ -138,6 +140,7 @@ void exportGraphWithAdditionalNodeProperties() {
138140

139141
@DisableForNeo4jVersion(Neo4jVersion.V_4_3)
140142
@DisableForNeo4jVersion(Neo4jVersion.V_4_4_drop10)
143+
@DisableForNeo4jVersion(Neo4jVersion.V_4_4_8_drop10)
141144
@Test
142145
void exportGraphWithAdditionalNodePropertiesShortHandSyntax() {
143146
projectGraph();

0 commit comments

Comments
 (0)