Merge pull request #3590 from pvdspek/fix-apiproperty-array-with-undefined-enum

fix: missing ApiProperty enum undefined on array handling

Author: kamilmysliwiec

lib/decorators/api-property.decorator.ts

@@ -36,7 +36,7 @@ const isEnumArray = (
   enum: EnumAllowedTypes;
   type: any;
   items: any;
-} => opts.isArray && 'enum' in opts;
+} => opts.isArray && 'enum' in opts && opts.enum !== undefined;
 
 /**
  * @publicApi

test/services/schema-object-factory.spec.ts

@@ -664,6 +664,32 @@ describe('SchemaObjectFactory', () => {
         required: ['testString']
       });
     });
+
+    it('should not use undefined enum on array', () => {
+      class TestDto {
+        @ApiProperty({
+          type: 'string',
+          isArray: true,
+          enum: undefined
+        })
+        testStringArray: string[];
+      }
+
+      const schemas = {};
+      schemaObjectFactory.exploreModelSchema(TestDto, schemas);
+      expect(schemas[TestDto.name]).toEqual({
+        type: 'object',
+        properties: {
+          testStringArray: {
+            type: 'array',
+            items: {
+              type: 'string'
+            }
+          }
+        },
+        required: ['testStringArray']
+      });
+    });
   });
 
   describe('createEnumSchemaType', () => {