Resolving sanity errors

Author: sivakasi-cisco

plugins/action/dtc/manage_child_fabric_vrfs.py

@@ -90,7 +90,6 @@ def run(self, tmp=None, task_vars=None):
 
         child_fabrics = msite_data['child_fabrics_data']
 
-
         network_os = task_vars['ansible_network_os']
         rest_module = get_rest_module(network_os)
         if not rest_module:

plugins/action/dtc/rest.py

@@ -1,6 +1,3 @@
-#!/usr/bin/python
-# -*- coding: utf-8 -*-
-
 # Copyright (c) 2024 Cisco Systems, Inc. and its affiliates
 #
 # Permission is hereby granted, free of charge, to any person obtaining a copy of
@@ -57,11 +54,11 @@ def run(self, tmp=None, task_vars=None):
 
         # Get task arguments
         module_args = self._task.args.copy()
-        
+
         # Get the network OS from task variables or module arguments
         network_os = task_vars.get('ansible_network_os')
         display.vvvv(f"Using OS module: {network_os}")
-        
+
         # Determine which module to use based on network_os
         rest_module = get_rest_module(network_os)
         if not rest_module:
@@ -79,7 +76,7 @@ def run(self, tmp=None, task_vars=None):
             # Set the connection to httpapi
             if 'connection' not in task_vars:
                 task_vars['connection'] = 'httpapi'
-                
+
             # Execute the appropriate REST module
             result = self._execute_module(
                 module_name=rest_module,
@@ -88,7 +85,7 @@ def run(self, tmp=None, task_vars=None):
                 tmp=tmp,
                 wrap_async=False
             )
-            
+
             # Update results with the module's results
             if result.get('failed'):
                 results.update(result)
@@ -97,7 +94,7 @@ def run(self, tmp=None, task_vars=None):
                 results['changed'] = result.get('changed', False)
                 results.update(result)
                 display.vvvv(f"Module execution successful: {result}")
-                
+
         except Exception as e:
             import traceback
             error_trace = traceback.format_exc()

roles/dtc/create/tasks/common/devices_discovery.yml

@@ -100,5 +100,3 @@
     path: "/appcenter/cisco/ndfc/api/v1/lan-fabric/rest/control/policies/{{ policy_ids }}/bulk"
     json_data: "{{ results.policy_update.values() | list | to_json }}"
   when: results.policy_update | length > 0
-
-

roles/dtc/create/tasks/external/devices_discovery.yml

@@ -57,6 +57,4 @@
     method: PUT
     path: "/appcenter/cisco/ndfc/api/v1/lan-fabric/rest/control/policies/{{ policy_ids }}/bulk"
     json_data: "{{ results.policy_update.values() | list | to_json }}"
-  when: results.policy_update | length > 0
-
-
+  when: results.policy_update | length > 0

tests/sanity/ignore-2.14.txt

@@ -36,6 +36,7 @@ plugins/action/dtc/unmanaged_edge_connections.py action-plugin-docs # action plu
 plugins/action/dtc/get_poap_data.py action-plugin-docs # action plugin has no matching module to provide documentation
 plugins/action/dtc/map_msd_inventory.py action-plugin-docs # action plugin has no matching module to provide documentation
 plugins/action/dtc/existing_links_check.py action-plugin-docs # action plugin has no matching module to provide documentation
+plugins/action/dtc/rest.py action-plugin-docs # action plugin has no matching module to provide documentation
 plugins/action/dtd/prepare_service_model.py action-plugin-docs # action plugin has no matching module to provide documentation
 plugins/action/test/inventory.py action-plugin-docs # action plugin has no matching module to provide documentation
 plugins/action/common/nac_dc_validate.py import-3.10!skip

tests/sanity/ignore-2.15.txt

@@ -36,6 +36,7 @@ plugins/action/dtc/unmanaged_edge_connections.py action-plugin-docs # action plu
 plugins/action/dtc/get_poap_data.py action-plugin-docs # action plugin has no matching module to provide documentation
 plugins/action/dtc/map_msd_inventory.py action-plugin-docs # action plugin has no matching module to provide documentation
 plugins/action/dtc/existing_links_check.py action-plugin-docs # action plugin has no matching module to provide documentation
+plugins/action/dtc/rest.py action-plugin-docs # action plugin has no matching module to provide documentation
 plugins/action/dtd/prepare_service_model.py action-plugin-docs # action plugin has no matching module to provide documentation
 plugins/action/test/inventory.py action-plugin-docs # action plugin has no matching module to provide documentation
 plugins/action/common/nac_dc_validate.py import-3.10!skip

tests/sanity/ignore-2.16.txt

@@ -36,6 +36,7 @@ plugins/action/dtc/unmanaged_edge_connections.py action-plugin-docs # action plu
 plugins/action/dtc/get_poap_data.py action-plugin-docs # action plugin has no matching module to provide documentation
 plugins/action/dtc/map_msd_inventory.py action-plugin-docs # action plugin has no matching module to provide documentation
 plugins/action/dtc/existing_links_check.py action-plugin-docs # action plugin has no matching module to provide documentation
+plugins/action/dtc/rest.py action-plugin-docs # action plugin has no matching module to provide documentation
 plugins/action/dtd/prepare_service_model.py action-plugin-docs # action plugin has no matching module to provide documentation
 plugins/action/test/inventory.py action-plugin-docs # action plugin has no matching module to provide documentation
 plugins/action/common/nac_dc_validate.py import-3.10!skip

tests/sanity/ignore-2.17.txt

@@ -36,6 +36,7 @@ plugins/action/dtc/unmanaged_edge_connections.py action-plugin-docs # action plu
 plugins/action/dtc/get_poap_data.py action-plugin-docs # action plugin has no matching module to provide documentation
 plugins/action/dtc/map_msd_inventory.py action-plugin-docs # action plugin has no matching module to provide documentation
 plugins/action/dtc/existing_links_check.py action-plugin-docs # action plugin has no matching module to provide documentation
+plugins/action/dtc/rest.py action-plugin-docs # action plugin has no matching module to provide documentation
 plugins/action/dtd/prepare_service_model.py action-plugin-docs # action plugin has no matching module to provide documentation
 plugins/action/test/inventory.py action-plugin-docs # action plugin has no matching module to provide documentation
 plugins/action/common/nac_dc_validate.py import-3.10!skip