saveCache() is atomic [Closes #11]

dg · dg · commit b703b4f59558 · 2017-07-18T02:09:56.000+02:00
diff --git a/src/RobotLoader/RobotLoader.php b/src/RobotLoader/RobotLoader.php
@@ -410,9 +410,10 @@ private function loadCache()
 	private function saveCache()
 	{
 		$file = $this->getCacheFile();
+		$tempFile = $file . uniqid('', true) . '.tmp';
 		$code = "<?php\nreturn " . var_export([$this->classes, $this->missing], true) . ";\n";
-		if (file_put_contents("$file.tmp", $code) !== strlen($code) || !rename("$file.tmp", $file)) {
-			@unlink("$file.tmp"); // @ - file may not exist
+		if (file_put_contents($tempFile, $code) !== strlen($code) || !rename($tempFile, $file)) {
+			@unlink($tempFile); // @ - file may not exist
 			throw new \RuntimeException("Unable to create '$file'.");
 		}
 		if (function_exists('opcache_invalidate')) {

Original file line number	Diff line number	Diff line change
`@@ -410,9 +410,10 @@ private function loadCache()`
`410`	`410`	`private function saveCache()`
`411`	`411`	`{`
`412`	`412`	`$file = $this->getCacheFile();`
	`413`	`+ $tempFile = $file . uniqid('', true) . '.tmp';`
`413`	`414`	`$code = "<?php\nreturn " . var_export([$this->classes, $this->missing], true) . ";\n";`
`414`		`- if (file_put_contents("$file.tmp", $code) !== strlen($code) \|\| !rename("$file.tmp", $file)) {`
`415`		`- @unlink("$file.tmp"); // @ - file may not exist`
	`415`	`+ if (file_put_contents($tempFile, $code) !== strlen($code) \|\| !rename($tempFile, $file)) {`
	`416`	`+ @unlink($tempFile); // @ - file may not exist`
`416`	`417`	`throw new \RuntimeException("Unable to create '$file'.");`
`417`	`418`	`}`
`418`	`419`	`if (function_exists('opcache_invalidate')) {`