listen completions of the remote operation

Signed-off-by: alperozturk <[email protected]>

Author: alperozturk96

app/src/main/java/com/owncloud/android/datamodel/FileDataStorageManager.java

@@ -1769,13 +1769,29 @@ public void saveSharesFromRemoteFile(List<RemoteFile> shares) {
             return;
         }
 
-        final ArrayList<ContentProviderOperation> operations = prepareInsertSharesFromRemoteFile(shares);
+        // Prepare reset operations
+        Set<String> uniquePaths = new HashSet<>();
+        for (RemoteFile share : shares) {
+            uniquePaths.add(share.getRemotePath());
+        }
 
-        if (operations.isEmpty()) {
-            return;
+        ArrayList<ContentProviderOperation> resetOperations = new ArrayList<>();
+        for (String path : uniquePaths) {
+            resetShareFlagInAFile(path);
+            var removeOps = prepareRemoveSharesInFile(path, new ArrayList<>());
+            if (!removeOps.isEmpty()) {
+                resetOperations.addAll(removeOps);
+            }
+        }
+        if (!resetOperations.isEmpty()) {
+            applyBatch(resetOperations);
         }
 
-        applyBatch(operations);
+        // Prepare insert operations
+        ArrayList<ContentProviderOperation> insertOperations = prepareInsertSharesFromRemoteFile(shares);
+        if (!insertOperations.isEmpty()) {
+            applyBatch(insertOperations);
+        }
     }
 
     /**
@@ -1798,7 +1814,7 @@ private ArrayList<ContentProviderOperation> prepareInsertSharesFromRemoteFile(It
             contentValueList.addAll(contentValues);
         }
 
-        final ArrayList<ContentProviderOperation> operations = new ArrayList<>();
+        ArrayList<ContentProviderOperation> operations = new ArrayList<>();
         for (ContentValues contentValues : contentValueList) {
             operations.add(ContentProviderOperation
                                .newInsert(ProviderTableMeta.CONTENT_URI_SHARE)

app/src/main/java/com/owncloud/android/ui/fragment/FileDetailSharingFragment.java

@@ -83,6 +83,7 @@
 import androidx.fragment.app.Fragment;
 import androidx.recyclerview.widget.LinearLayoutManager;
 import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
+import kotlin.Unit;
 
 public class FileDetailSharingFragment extends Fragment implements ShareeListAdapterListener,
     DisplayUtils.AvatarGenerationListener,
@@ -154,15 +155,14 @@ public void onCreate(@Nullable Bundle savedInstanceState) {
 
         fileDataStorageManager = fileActivity.getStorageManager();
         ShareRepository shareRepository = new RemoteShareRepository(fileActivity.getClientRepository(), fileActivity, fileDataStorageManager);
-        shareRepository.refreshSharesForFolder(file.getRemotePath());
-    }
-
-    @Override
-    public void onActivityCreated(Bundle savedInstanceState) {
-        super.onActivityCreated(savedInstanceState);
-
-        refreshCapabilitiesFromDB();
-        refreshSharesFromDB();
+        shareRepository.refreshSharesForFile(file.getRemotePath(), () -> {
+            refreshCapabilitiesFromDB();
+            refreshSharesFromDB();
+            return Unit.INSTANCE;
+        }, () -> {
+            DisplayUtils.showSnackMessage(getView(), R.string.error_fetching_sharees);
+            return Unit.INSTANCE;
+        });
     }
 
     @Override
@@ -200,7 +200,7 @@ public View onCreateView(@NonNull LayoutInflater inflater, ViewGroup container,
                               SharesType.EXTERNAL);
 
         externalShareeListAdapter.setHasStableIds(true);
-        
+
         binding.sharesListExternal.setAdapter(externalShareeListAdapter);
 
         binding.sharesListExternal.setLayoutManager(new LinearLayoutManager(requireContext()));

app/src/main/java/com/owncloud/android/ui/fragment/share/RemoteShareRepository.kt

@@ -15,6 +15,7 @@ import com.owncloud.android.lib.common.utils.Log_OC
 import com.owncloud.android.operations.GetSharesForFileOperation
 import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.launch
+import kotlinx.coroutines.withContext
 
 class RemoteShareRepository(
     private val clientRepository: ClientRepository,
@@ -24,7 +25,7 @@ class RemoteShareRepository(
     private val tag = "RemoteShareRepository"
     private val scope = lifecycleOwner.lifecycleScope
 
-    override fun refreshSharesForFolder(remotePath: String) {
+    override fun refreshSharesForFile(remotePath: String, onCompleted: () -> Unit, onError: () -> Unit) {
         scope.launch(Dispatchers.IO) {
             val client = clientRepository.getOwncloudClient() ?: return@launch
             val operation =
@@ -40,13 +41,17 @@ class RemoteShareRepository(
 
             Log_OC.i(tag, "Remote path for the refresh shares: $remotePath")
 
-            if (result.isSuccess) {
-                Log_OC.d(tag, "Successfully refreshed shares for the specified remote path.")
-            } else {
-                Log_OC.w(
-                    tag,
-                    "Failed to refresh shares for the specified remote path. An error occurred during the operation."
-                )
+            withContext(Dispatchers.Main) {
+                if (result.isSuccess) {
+                    Log_OC.d(tag, "Successfully refreshed shares for the specified remote path.")
+                    onCompleted()
+                } else {
+                    Log_OC.w(
+                        tag,
+                        "Failed to refresh shares for the specified remote path. An error occurred during the operation."
+                    )
+                    onError()
+                }
             }
         }
     }

app/src/main/java/com/owncloud/android/ui/fragment/share/ShareRepository.kt

@@ -8,5 +8,5 @@
 package com.owncloud.android.ui.fragment.share
 
 interface ShareRepository {
-    fun refreshSharesForFolder(remotePath: String)
+    fun refreshSharesForFile(remotePath: String, onCompleted: () -> Unit, onError: () -> Unit)
 }

app/src/main/res/values/strings.xml

@@ -882,6 +882,7 @@
     <string name="create_new_folder">New folder</string>
     <string name="uploads_view_upload_status_virus_detected">Virus detected. Upload cannot be completed!</string>
     <string name="tags">Tags</string>
+    <string name="error_fetching_sharees">Unable to fetch sharees.</string>
     <string name="sharee_add_failed">Adding sharee failed</string>
     <string name="sharee_already_added_to_file">Adding share failed. This file or folder has already been shared with this person or group.</string>
     <string name="unsharing_failed">Unsharing failed</string>