Instrumentation tests now automatically grab the notifications permission

Before that, when starting individual tests from the command line or from
inside the IDE, they could fail because a dialog asking for the permission
to post notifications was blocking the view.

While we are on it, added a small explanation to the other existing rule.
Without that explanation it might be unclear why this is not also done via
the same GrantPermissionRule used for the notifications.

Signed-off-by: Philipp Hasper <[email protected]>

Author: PhilLab

app/src/androidTest/java/com/nextcloud/test/GrantStoragePermissionRule.kt

@@ -15,6 +15,10 @@ import org.junit.rules.TestRule
 import org.junit.runner.Description
 import org.junit.runners.model.Statement
 
+/**
+ * Rule to automatically enable the test to write to the external storage.
+ * Depending on the SDK version, different approaches might be necessary to achieve the full access.
+ */
 class GrantStoragePermissionRule private constructor() {
 
     companion object {
@@ -30,6 +34,7 @@ class GrantStoragePermissionRule private constructor() {
     private class GrantManageExternalStoragePermissionRule : TestRule {
         override fun apply(base: Statement, description: Description): Statement = object : Statement() {
             override fun evaluate() {
+                // Refer to https://developer.android.com/training/data-storage/manage-all-files#enable-manage-external-storage-for-testing
                 InstrumentationRegistry.getInstrumentation().uiAutomation.executeShellCommand(
                     "appops set --uid ${InstrumentationRegistry.getInstrumentation().targetContext.packageName} " +
                         "MANAGE_EXTERNAL_STORAGE allow"

app/src/androidTest/java/com/owncloud/android/AbstractIT.java

@@ -6,6 +6,7 @@
  */
 package com.owncloud.android;
 
+import android.Manifest;
 import android.accounts.Account;
 import android.accounts.AccountManager;
 import android.accounts.AuthenticatorException;
@@ -78,6 +79,7 @@
 import androidx.test.espresso.contrib.DrawerActions;
 import androidx.test.espresso.intent.rule.IntentsTestRule;
 import androidx.test.platform.app.InstrumentationRegistry;
+import androidx.test.rule.GrantPermissionRule;
 import androidx.test.runner.lifecycle.ActivityLifecycleMonitorRegistry;
 import androidx.test.runner.lifecycle.Stage;
 
@@ -93,7 +95,10 @@
  */
 public abstract class AbstractIT {
     @Rule
-    public final TestRule permissionRule = GrantStoragePermissionRule.grant();
+    public final TestRule storagePermissionRule = GrantStoragePermissionRule.grant();
+
+    @Rule
+    public GrantPermissionRule notificationsPermissionRule = GrantPermissionRule.grant(Manifest.permission.POST_NOTIFICATIONS);
 
     protected static OwnCloudClient client;
     protected static NextcloudClient nextcloudClient;