fix share creation via allow download and sync option

alperozturk96 · alperozturk96 · commit c875ba403be5 · 2025-07-02T14:45:59.000+02:00
Signed-off-by: alperozturk &lt;alper_ozturk@proton.me&gt;
diff --git a/app/src/androidTest/java/com/nextcloud/utils/SharePermissionManagerTest.kt b/app/src/androidTest/java/com/nextcloud/utils/SharePermissionManagerTest.kt
@@ -256,7 +256,8 @@ class SharePermissionManagerTest {
             shareType = ShareType.USER
             permissions = 17
         }
-        ocShare.attributes = ocShare.toggleAllowDownloadAndSync(
+        ocShare.attributes = toggleAllowDownloadAndSync(
+            ocShare.attributes,
             isChecked = true,
             useV2DownloadAttributes = false
         )
diff --git a/app/src/main/java/com/owncloud/android/ui/fragment/FileDetailsSharingProcessFragment.kt b/app/src/main/java/com/owncloud/android/ui/fragment/FileDetailsSharingProcessFragment.kt
@@ -656,7 +656,7 @@ class FileDetailsSharingProcessFragment :
 
         if (!isPublicShare()) {
             binding.shareAllowDownloadAndSyncCheckbox.setOnCheckedChangeListener { _, isChecked ->
-                val result = share.toggleAllowDownloadAndSync(isChecked, useV2DownloadAttributes())
+                val result = toggleAllowDownloadAndSync(share?.attributes, isChecked, useV2DownloadAttributes())
                 share?.attributes = result
                 downloadAttribute = result
             }
diff --git a/build.gradle b/build.gradle
@@ -10,7 +10,7 @@
  */
 buildscript {
     ext {
-        androidLibraryVersion ="4c342f9031"
+        androidLibraryVersion ="8514831f30"
         androidCommonLibraryVersion = "0.26.0"
         androidPluginVersion = "8.9.2"
         androidxMediaVersion = "1.5.1"
diff --git a/gradle/verification-metadata.xml b/gradle/verification-metadata.xml
@@ -12597,6 +12597,14 @@
             <sha256 value="de2e7d2fdde1d6981af8fcd54812dfe510ab7e22bdf8225ed569616b6c1155f4" origin="Generated by Gradle" reason="Artifact is not signed"/>
          </artifact>
       </component>
+      <component group="com.github.nextcloud" name="android-library" version="8514831f30">
+         <artifact name="android-library-8514831f30.aar">
+            <sha256 value="3306e4c894ae616dbae2579079b23bd07fe8114045e21fb53f198ce675052e06" origin="Generated by Gradle" reason="Artifact is not signed"/>
+         </artifact>
+         <artifact name="android-library-8514831f30.module">
+            <sha256 value="28848cb53868af301c356100ab5221078475c907b709603545d70e522bc9e78c" origin="Generated by Gradle" reason="Artifact is not signed"/>
+         </artifact>
+      </component>
       <component group="com.github.nextcloud" name="android-library" version="856c2516c6dd92058535d726ab55f0aef19ee089">
          <artifact name="android-library-856c2516c6dd92058535d726ab55f0aef19ee089.aar">
             <sha256 value="dc7c01113fc8333aa61ead05bc5058f65857f9d57448b7328f26db24922b6662" origin="Generated by Gradle" reason="Artifact is not signed"/>

Original file line number	Diff line number	Diff line change
`@@ -256,7 +256,8 @@ class SharePermissionManagerTest {`
`256`	`256`	`shareType = ShareType.USER`
`257`	`257`	`permissions = 17`
`258`	`258`	`}`
`259`		`- ocShare.attributes = ocShare.toggleAllowDownloadAndSync(`
	`259`	`+ ocShare.attributes = toggleAllowDownloadAndSync(`
	`260`	`+ ocShare.attributes,`
`260`	`261`	`isChecked = true,`
`261`	`262`	`useV2DownloadAttributes = false`
`262`	`263`	`)`
Original file line number	Diff line number	Diff line change
`@@ -656,7 +656,7 @@ class FileDetailsSharingProcessFragment :`
`656`	`656`
`657`	`657`	`if (!isPublicShare()) {`
`658`	`658`	`binding.shareAllowDownloadAndSyncCheckbox.setOnCheckedChangeListener { _, isChecked ->`
`659`		`- val result = share.toggleAllowDownloadAndSync(isChecked, useV2DownloadAttributes())`
	`659`	`+ val result = toggleAllowDownloadAndSync(share?.attributes, isChecked, useV2DownloadAttributes())`
`660`	`660`	`share?.attributes = result`
`661`	`661`	`downloadAttribute = result`
`662`	`662`	`}`