add test for pool

Signed-off-by: Lukas Schaefer <[email protected]>

Author: lukasdotcom

lib/Service/QuotaRuleService.php

@@ -48,8 +48,6 @@ public function getRule(int $quotaType, string $userId) {
 					'pool' => false,
 					'id' => null,
 				];
-				$cache->set($cacheKey, $rule);
-				return $rule;
 			}
 			$cache->set($cacheKey, $rule);
 		}

tests/unit/Providers/OpenAiProviderTest.php

@@ -17,6 +17,7 @@
 use OCA\OpenAi\Service\ChunkService;
 use OCA\OpenAi\Service\OpenAiAPIService;
 use OCA\OpenAi\Service\OpenAiSettingsService;
+use OCA\OpenAi\Service\QuotaRuleService;
 use OCA\OpenAi\TaskProcessing\ChangeToneProvider;
 use OCA\OpenAi\TaskProcessing\EmojiProvider;
 use OCA\OpenAi\TaskProcessing\HeadlineProvider;
@@ -82,6 +83,7 @@ protected function setUp(): void {
 			\OC::$server->get(ICacheFactory::class),
 			\OC::$server->get(QuotaUsageMapper::class),
 			$this->openAiSettingsService,
+			\OC::$server->get(QuotaRuleService::class),
 			$clientService,
 		);
 

tests/unit/Quota/QuotaTest.php

@@ -0,0 +1,134 @@
+<?php
+
+/**
+ * SPDX-FileCopyrightText: 2025 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ *
+ *
+ * This unit test is designed to test the pool quota functionality
+ */
+
+namespace OCA\OpenAi\Tests\Unit\Quota;
+
+use Exception;
+use OC;
+use OCA\OpenAi\AppInfo\Application;
+use OCA\OpenAi\Db\QuotaUsageMapper;
+use OCA\OpenAi\Service\OpenAiAPIService;
+use OCA\OpenAi\Service\OpenAiSettingsService;
+use OCA\OpenAi\Service\QuotaRuleService;
+use OCP\Http\Client\IClientService;
+use OCP\IAppConfig;
+use OCP\ICacheFactory;
+use OCP\IL10N;
+use OCP\IUserManager;
+use PHPUnit\Framework\MockObject\MockObject;
+use Psr\Log\LoggerInterface;
+use RuntimeException;
+use Test\TestCase;
+use Test\Util\User\Dummy;
+use Throwable;
+
+/**
+ * @group DB
+ */
+class QuotaTest extends TestCase {
+	public const APP_NAME = 'integration_openai';
+	public const TEST_USER1 = 'testuser1';
+	public const TEST_USER2 = 'testuser2';
+
+	private OpenAiAPIService $openAiApiService;
+	private OpenAiSettingsService $openAiSettingsService;
+	/**
+	 * @var MockObject|ICacheFactory
+	 */
+	private $cacheFactory;
+	private QuotaUsageMapper $quotaUsageMapper;
+	private QuotaRuleService $quotaRuleService;
+
+	public static function setUpBeforeClass(): void {
+		parent::setUpBeforeClass();
+		$backend = new Dummy();
+		$backend->createUser(self::TEST_USER1, self::TEST_USER1);
+		$backend->createUser(self::TEST_USER2, self::TEST_USER2);
+		OC::$server->get(IUserManager::class)->registerBackend($backend);
+	}
+
+	protected function setUp(): void {
+		parent::setUp();
+
+		$this->loginAsUser(self::TEST_USER1);
+
+		$this->openAiSettingsService = OC::$server->get(OpenAiSettingsService::class);
+
+		$this->quotaUsageMapper = OC::$server->get(QuotaUsageMapper::class);
+
+		$this->cacheFactory = $this->createMock(ICacheFactory::class);
+
+		$this->quotaRuleService = OC::$server->get(QuotaRuleService::class);
+
+
+		$this->openAiApiService = new OpenAiAPIService(
+			OC::$server->get(LoggerInterface::class),
+			$this->createMock(IL10N::class),
+			OC::$server->get(IAppConfig::class),
+			$this->cacheFactory,
+			OC::$server->get(QuotaUsageMapper::class),
+			$this->openAiSettingsService,
+			\OC::$server->get(QuotaRuleService::class),
+			OC::$server->get(IClientService::class),
+		);
+	}
+
+	public static function tearDownAfterClass(): void {
+		// Delete quota usage for test user
+		$quotaUsageMapper = OC::$server->get(QuotaUsageMapper::class);
+		try {
+			$quotaUsageMapper->deleteUserQuotaUsages(self::TEST_USER1);
+		} catch (\OCP\Db\Exception|RuntimeException|Exception|Throwable $e) {
+			// Ignore
+		}
+		$rules = OC::$server->get(QuotaRuleService::class)->getRules();
+		foreach ($rules as $rule) {
+			OC::$server->get(QuotaRuleService::class)->deleteRule($rule['id']);
+		}
+
+		$backend = new Dummy();
+		$backend->deleteUser(self::TEST_USER1);
+		$backend->deleteUser(self::TEST_USER2);
+		OC::$server->get(IUserManager::class)->removeBackend($backend);
+
+		parent::tearDownAfterClass();
+	}
+
+	public function testQuotaPool(): void {
+		// Create a quota rule for both test users as a pool
+		$this->openAiSettingsService->setQuotas([1000, 1, 1, 1]);
+		$rule = $this->quotaRuleService->addRule();
+		$rule['type'] = Application::QUOTA_TYPE_TEXT;
+		$rule['amount'] = 10;
+		$rule['pool'] = true;
+		$rule['entities'] = [
+			[
+				'entity_id' => self::TEST_USER1,
+				'entity_type' => 'user',
+			],
+			[
+				'entity_id' => self::TEST_USER2,
+				'entity_type' => 'user',
+			]
+		];
+		$this->quotaRuleService->updateRule($rule['id'], $rule);
+
+		$this->assertFalse($this->openAiApiService->isQuotaExceeded(self::TEST_USER1, Application::QUOTA_TYPE_TEXT));
+		$this->quotaUsageMapper->createQuotaUsage(self::TEST_USER1, Application::QUOTA_TYPE_TEXT, 100, $rule['id']);
+
+		$this->assertTrue($this->openAiApiService->isQuotaExceeded(self::TEST_USER1, Application::QUOTA_TYPE_TEXT));
+		// Check other user
+		$this->assertTrue($this->openAiApiService->isQuotaExceeded(self::TEST_USER2, Application::QUOTA_TYPE_TEXT));
+		// Clear quota usage
+		$this->quotaUsageMapper->deleteUserQuotaUsages(self::TEST_USER1);
+		$this->quotaUsageMapper->deleteUserQuotaUsages(self::TEST_USER2);
+	}
+
+}