fix translation

Signed-off-by: nabim777 <[email protected]>

Author: nabim777

src/constants/messages.js

@@ -21,10 +21,13 @@ export const messages = {
 	tokenExchangeHintText: t(APP_ID, 'When enabled, the app will try to obtain a token for the given audience from the identity provider. If disabled, it will use the access token obtained during the login process.'),
 	opRequiredVersionAndPlanHint: t(APP_ID, 'Requires OpenProject version {version} (or higher) and an active Corporate plan.', { version: OPENPROJECT_VERSION }),
 	pleaseSelectProject: t(APP_ID, 'Please select a project'),
+	noMachingWorkProjectsFound: t(APP_ID, 'No matching work projects found'),
+	noMachingStausFound: t(APP_ID, 'No matching status found'),
+	noMachingTypeFound: t(APP_ID, 'No matching type found'),
+	noMachingAssigneeFound: t(APP_ID, 'No matching assignee found'),
 }
 
 export const messagesFmt = {
 	appNotEnabledOrUnsupported: (app, version) => t(APP_ID, 'This feature requires version {version} (or higher) of "{app}" app. Please install or update the app.', { app, version }),
 	configureOIDCProviders: (settingsLink) => t(APP_ID, 'You can configure OIDC providers in the {settingsLink}', { settingsLink }, null, { escape: false, sanitize: false }),
-	noMachingFound: (fieldName) => t(APP_ID, 'No matching {fieldName} found', { fieldName }),
 }

src/views/CreateWorkPackageModal.vue

@@ -171,7 +171,7 @@ import { loadState } from '@nextcloud/initial-state'
 import { translate as t } from '@nextcloud/l10n'
 import { STATE } from '../utils.js'
 import debounce from 'lodash/debounce.js'
-import { messages, messagesFmt } from '../constants/messages.js'
+import { messages } from '../constants/messages.js'
 
 const SEARCH_CHAR_LIMIT = 1
 const DEBOUNCE_THRESHOLD = 500
@@ -304,7 +304,7 @@ export default {
 		},
 		getNoOptionTextForProject() {
 			if (this.availableProjects.length === 0) {
-				return messagesFmt.noMachingFound('work projects')
+				return messages.noMachingWorkProjectsFound
 			}
 			// while projects are being searched we make the no text option empty
 			return ''
@@ -621,7 +621,14 @@ export default {
 			if (this.project.label === null) {
 				return messages.pleaseSelectProject
 			}
-			return messagesFmt.noMachingFound(fieldName)
+			if (fieldName === 'assignee') {
+				return messages.noMachingAssigneeFound
+			} else if (fieldName === 'type') {
+				return messages.noMachingTypeFound
+			} else if (fieldName === 'status') {
+				return messages.noMachingStausFound
+			}
+			return ''
 		},
 		async setAvailableAssigneesForProject(projectId) {
 			this.availableAssignees = []

tests/jest/views/CreateWorkpackageModal.spec.js

@@ -18,7 +18,7 @@ import availableProjectAssignees from '../fixtures/availableProjectAssigneesResp
 import workpackageCreatedResponse from '../fixtures/workPackageSuccessfulCreationResponse.json'
 import requiredTypeResponse from '../fixtures/formValidationResponseRequiredType.json'
 import CreateWorkPackageModal from '../../../src/views/CreateWorkPackageModal.vue'
-import { messagesFmt, messages } from '../../../src/constants/messages.js'
+import { messages } from '../../../src/constants/messages.js'
 
 const localVue = createLocalVue()
 jest.mock('@nextcloud/dialogs', () => ({
@@ -133,7 +133,7 @@ describe('CreateWorkPackageModal.vue', () => {
 					},
 				)
 				const searchResult = wrapper.find(firstProjectSelector)
-				expect(searchResult.text()).toBe(messagesFmt.noMachingFound('work projects'))
+				expect(searchResult.text()).toBe(messages.noMachingWorkProjectsFound)
 			})
 
 			it.each([
@@ -176,7 +176,7 @@ describe('CreateWorkPackageModal.vue', () => {
 					},
 				)
 				const searchResult = wrapper.find(firstProjectSelector)
-				expect(searchResult.text()).toBe(messagesFmt.noMachingFound('work projects'))
+				expect(searchResult.text()).toBe(messages.noMachingWorkProjectsFound)
 				expect(inputField.element.value).toBe('Scw')
 
 				// Trigger blur event (user moves to another field)
@@ -708,21 +708,21 @@ describe('CreateWorkPackageModal.vue', () => {
 				fieldName: 'type',
 				inputSelector: typeInputFieldSelector,
 				resultSelector: firstTypeSelector,
-				expectedMessage: 'No matching type found',
+				expectedMessage: messages.noMachingTypeFound,
 			},
 			{
 				fieldName: 'status',
 				inputSelector: statusInputFieldSelector,
 				resultSelector: firstStatusSelector,
-				expectedMessage: 'No matching status found',
+				expectedMessage: messages.noMachingStausFound,
 			},
 			{
 				fieldName: 'assignee',
 				inputSelector: assigneeInputFieldSelector,
 				resultSelector: firstAssigneeSelector,
-				expectedMessage: 'No matching assignee found',
+				expectedMessage: messages.noMachingAssigneeFound,
 			},
-		])('should show $expectedMessage when project is set and there is no $fieldName found in search query', async ({ fieldName, inputSelector, resultSelector }) => {
+		])('should show $expectedMessage when project is set and there is no $fieldName found in search query', async ({ inputSelector, resultSelector, expectedMessage }) => {
 
 			wrapper = mountWrapper(true, {
 				project: {
@@ -740,7 +740,7 @@ describe('CreateWorkPackageModal.vue', () => {
 			await input.trigger('focus')
 
 			const searchResult = wrapper.find(resultSelector)
-			expect(searchResult.text()).toBe(messagesFmt.noMachingFound(fieldName))
+			expect(searchResult.text()).toBe(expectedMessage)
 		})
 	})