Skip to content

Commit 1c13849

Browse files
cod
Signed-off-by: Marino Faggiana <[email protected]>
1 parent 997de26 commit 1c13849

File tree

5 files changed

+15
-21
lines changed

5 files changed

+15
-21
lines changed

Share/NCShareExtension+DataSource.swift

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,12 @@ extension NCShareExtension: UICollectionViewDelegate {
2626
self.present(UIAlertController.warning(message: "\(fileNameError.errorDescription) \(NSLocalizedString("_please_rename_file_", comment: ""))"), animated: true)
2727
return
2828
}
29+
2930
self.serverUrl = serverUrl
30-
await self.reloadDatasource(withLoadFolder: true)
3131
self.setNavigationBar(navigationTitle: metadata.fileNameView)
32+
33+
await self.reloadData()
34+
await self.loadFolder()
3235
}
3336
}
3437

Share/NCShareExtension+Files.swift

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -9,19 +9,14 @@ import UniformTypeIdentifiers
99
import NextcloudKit
1010

1111
extension NCShareExtension {
12-
func reloadDatasource(withLoadFolder: Bool) async {
12+
func reloadData() async {
1313
let session = self.extensionData.getSession()
1414
let layoutForView = await NCManageDatabase.shared.getLayoutForViewAsync(account: session.account, key: keyLayout, serverUrl: serverUrl)
1515
let predicate = NSPredicate(format: "account == %@ AND serverUrl == %@ AND directory == true", session.account, serverUrl)
1616
let metadatas = await self.database.getMetadatasAsync(predicate: predicate,
1717
layoutForView: layoutForView,
1818
account: session.account)
1919
self.dataSource = NCCollectionViewDataSource(metadatas: metadatas, layoutForView: layoutForView, account: session.account)
20-
21-
if withLoadFolder {
22-
await self.loadFolder()
23-
}
24-
2520
self.collectionView.reloadData()
2621
}
2722

@@ -33,7 +28,7 @@ extension NCShareExtension {
3328
else { return }
3429

3530
self.serverUrl += "/" + metadata.fileName
36-
await self.reloadDatasource(withLoadFolder: true)
31+
await self.loadFolder()
3732
self.setNavigationBar(navigationTitle: metadata.fileNameView)
3833
}
3934
}
@@ -47,10 +42,9 @@ extension NCShareExtension {
4742

4843
if resultsReadFolder.error == .success {
4944
self.metadataFolder = resultsReadFolder.metadataFolder
50-
await self.reloadDatasource(withLoadFolder: false)
45+
await self.reloadData()
5146
} else {
5247
self.showAlert(description: resultsReadFolder.error.errorDescription)
53-
5448
}
5549
}
5650
}

Share/NCShareExtension+NCAccountRequestDelegate.swift

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ extension NCShareExtension: NCAccountRequestDelegate {
5757

5858
// COLORS
5959
NCBrandColor.shared.settingThemingColor(account: account)
60-
NotificationCenter.default.postOnMainThread(name: NCGlobal.shared.notificationCenterChangeTheming, userInfo: ["account": account])
6160

6261
// NETWORKING
6362
NextcloudKit.shared.setup(groupIdentifier: NCBrandOptions.shared.capabilitiesGroup, delegate: NCNetworking.shared)
@@ -78,8 +77,10 @@ extension NCShareExtension: NCAccountRequestDelegate {
7877

7978
serverUrl = utilityFileSystem.getHomeServer(session: session)
8079

81-
await reloadDatasource(withLoadFolder: true)
8280
setNavigationBar(navigationTitle: NCBrandOptions.shared.brand)
81+
82+
await reloadData()
83+
await loadFolder()
8384
}
8485
}
8586
}

Share/NCShareExtension.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ class NCShareExtension: UIViewController {
178178
while self.serverUrl.last != "/" { self.serverUrl.removeLast() }
179179
self.serverUrl.removeLast()
180180
Task {
181-
await self.reloadDatasource(withLoadFolder: true)
181+
await self.reloadData()
182182
}
183183
var navigationTitle = (self.serverUrl as NSString).lastPathComponent
184184
if self.utilityFileSystem.getHomeServer(session: session) == self.serverUrl {
@@ -246,7 +246,7 @@ class NCShareExtension: UIViewController {
246246
let alertController = UIAlertController.createFolder(serverUrl: serverUrl, session: session) { error in
247247
if error == .success {
248248
Task {
249-
await self.reloadDatasource(withLoadFolder: true)
249+
await self.loadFolder()
250250
}
251251
} else {
252252
self.showAlert(title: "_error_createsubfolders_upload_", description: error.errorDescription)

iOSClient/Main/Collection Common/NCCollectionViewCommon.swift

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -603,17 +603,13 @@ class NCCollectionViewCommon: UIViewController, UIGestureRecognizerDelegate, UIS
603603
spinner.centerYAnchor.constraint(equalTo: container.centerYAnchor)
604604
])
605605

606-
UIView.transition(with: navigationController!.navigationBar, duration: 0.25, options: .transitionCrossDissolve) {
607-
self.navigationItem.titleView = container
608-
}
606+
self.navigationItem.titleView = container
609607
}
610608

611609
@MainActor
612610
func restoreDefaultTitle() {
613-
UIView.transition(with: navigationController!.navigationBar, duration: 0.25, options: .transitionCrossDissolve) {
614-
self.navigationItem.titleView = nil
615-
self.navigationItem.title = self.titleCurrentFolder
616-
}
611+
self.navigationItem.titleView = nil
612+
self.navigationItem.title = self.titleCurrentFolder
617613
}
618614

619615
// MARK: - SEARCH

0 commit comments

Comments
 (0)