Skip to content

Conversation

@CreatorOfBiontium
Copy link
Contributor

A few changes, mainly focused on making email fully wide on phone, and a few design changes.
This is a split up of #11754
Fixes #11663

@CreatorOfBiontium
Copy link
Contributor Author

Hope I didn't forget anything @ChristophWurst. And while we are here, what to do with the animation, any suggestions, whether I should work on the way I did it in #11754 or leave it to someone else?

@ChristophWurst
Copy link
Member

I've pushed a small change to refactor how the mobile breakpoint works. Unfortunately using a css var for a media query is not supported yet. So we'll go with a SCSS var.

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested & works 🙏

@ChristophWurst ChristophWurst force-pushed the enh/display_full_mail_width branch from c0d358b to 0f8b91f Compare December 2, 2025 08:24
@ChristophWurst ChristophWurst changed the title enh: make email wide on phone feat: make email wide on phone Dec 2, 2025
@ChristophWurst
Copy link
Member

ChristophWurst commented Dec 2, 2025

Reworked the two commits. Main changes

  • Semantic commit message
  • Deduplicate CSS rules (stylelint error)
  • Fix left-to-right/right-to-left issues
  • ESLint issues

A few changes, mainly focused on making email fully wide on phone, and a few design changes.

Signed-off-by: Tobiáš Vašťák <[email protected]>
@ChristophWurst ChristophWurst force-pushed the enh/display_full_mail_width branch from 0f8b91f to 144d597 Compare December 2, 2025 08:30
@ChristophWurst
Copy link
Member

@CreatorOfBiontium please give this a final test to make sure I haven't lost anything in the clean-up 🙏

@ChristophWurst ChristophWurst force-pushed the enh/display_full_mail_width branch from 144d597 to b9ba12a Compare December 2, 2025 08:32
@CreatorOfBiontium
Copy link
Contributor Author

@ChristophWurst Thanks, I have a lot to do this week, so I’d probably fix it over the weekend. I’ll test this when I get home.

@CreatorOfBiontium
Copy link
Contributor Author

CreatorOfBiontium commented Dec 2, 2025

@ChristophWurst Tested and seems ok. My only concern is that in other languages, the unsub button is way too long, so it looks like this on narrow screens:
image

Do you think we should fix this here by like ellipsies? Or follow up in #12076 (or somewhere else) - but still I think it's not gonna be that easy, or maybe, idk.

@ChristophWurst
Copy link
Member

We can leave it out here and solve one bug at a time :)

@ChristophWurst ChristophWurst merged commit 6e95f1c into nextcloud:main Dec 2, 2025
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use full screen width on mobile

2 participants